From owner-svn-ports-head@freebsd.org Tue Jul 7 13:55:04 2020 Return-Path: Delivered-To: svn-ports-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 743F5363950; Tue, 7 Jul 2020 13:55:04 +0000 (UTC) (envelope-from lwhsu.freebsd@gmail.com) Received: from mail-yb1-f194.google.com (mail-yb1-f194.google.com [209.85.219.194]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4B1P8817p5z4dR4; Tue, 7 Jul 2020 13:55:03 +0000 (UTC) (envelope-from lwhsu.freebsd@gmail.com) Received: by mail-yb1-f194.google.com with SMTP id h39so20651560ybj.3; Tue, 07 Jul 2020 06:55:03 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=lp3v/1t0wcagk0ZPxLlM6Fr9LoU+VOM6wKKRh/kaug4=; b=NUnfp7fVT9ct6JsWCccd5/Q5orsrHaSTmh61MFQTi5NnpoReUND9a6oZBg3wKRN74+ wBjN4Dxteq4shQFdOin6szIVSV7eh46NjavMZEcQZ5+fj5yers7NNE12njEnkhYygAjx +Ttg8wZJBCc4FvTGL7XWakE8Z/kb5b7uUuHq+1i4Xf21VBF+6ITCLKIB0SAQ3IDuGd15 yqQX+oPehjufA1sRkhP2XvrSWP1ZsviF0h6DggNN8yClfMyWSjw12f/MlprPhNiIRApy zoPSLcQPnGdFaisa/xoFCqkrjj31PaesbA0shlJjSWbjf2+3C7RydeQ37aPFAfeclY4F 2R3Q== X-Gm-Message-State: AOAM531o876DAnAD0+kURCMoNo7r3qFruobTRsJehORO0XzQpjD6ti5M 0vs4TGWH6yRhN9Xi0LY2t2saSudN0wjl7IAi8Zf/owITlFM= X-Google-Smtp-Source: ABdhPJwEfejyO79FOaQbjG6MCWZ1REOXTJ2chMHMuPVjFWXsKH8axEnyTETDEPtQFEx06bLaxAUyfZgmcoHsur/C+14= X-Received: by 2002:a25:b211:: with SMTP id i17mr76970762ybj.241.1594130102485; Tue, 07 Jul 2020 06:55:02 -0700 (PDT) MIME-Version: 1.0 References: <202007071227.067CRINg025699@repo.freebsd.org> In-Reply-To: From: Li-Wen Hsu Date: Tue, 7 Jul 2020 21:54:51 +0800 Message-ID: Subject: Re: svn commit: r541417 - in head: audio/bambootracker audio/zynaddsubfx comms/nanovna-saver comms/openzwave-devel comms/telldus-core comms/tlf databases/arrow deskutils/cairo-dock-plugins devel/bossa ... To: Tobias Kortkamp Cc: ports-committers , svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 4B1P8817p5z4dR4 X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US]; TAGGED_FROM(0.00)[] X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 07 Jul 2020 13:55:04 -0000 On Tue, Jul 7, 2020 at 9:11 PM Tobias Kortkamp wrote: > > On Tue, Jul 7, 2020, at 12:53, Li-Wen Hsu wrote: > > On Tue, Jul 7, 2020 at 8:27 PM Tobias Kortkamp wrote: > > > > > > Author: tobik > > > Date: Tue Jul 7 12:27:18 2020 > > > New Revision: 541417 > > > URL: https://svnweb.freebsd.org/changeset/ports/541417 > > > > > > Log: > > > Clean up some things > > > > > > Reported by: portscan and common sense > > > > Hi Tobias, > > > > I am somehow worried that this commit might cause some people's > > objection. It does fix many things, which is great, but also: > > - Changed (direct) dependency but not bump PORTREVISION (comms/nanovna-saver) > > I did not change any dependencies. What did I miss? oh I mean direct dependency, it drops qt5 directly. It's not a serious issue, though. > > - Touched some style preference (print/pdfchain) > > The previous style causes active harm in readability and causes > additional cognitve load on committers. See the commit message of > r541362 for a direct example of this. Also style fixes are very > much covered by the blanket. I quote chapter 5.5 from the Porter's > Handbook: > > "We reserve the right to modify the maintainer's submission to better > match existing policies and style of the Ports Collection without > explicit blessing from the submitter or the maintainer. Also, large > infrastructural changes can result in a port being modified without > the maintainer's consent. These kinds of changes will never affect > the port's functionality." > > https://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/makefile-maintainer.html > > For pdfchain it IMHO should have been done before the initial import into > the tree. Yeah I also noticed that r541362 and rethinking if I should change that while importing. I didn't do that because I wasn't aware that there is a strict rule about this and it still has some benefits, e.g., easier to track adding/deleting. I chose to leave as it is because I wanted to respect the submitter's choice. Anyway, I'm fine with both styles. > > - Without notifying port's maintainer nor not having approval from porgmr > > > > Sorry that if I didn't notice there was a policy change that those > > changes are also covered by blanket approval, and I'm a bit worried > > about the last one, maybe the better way is file a PR with the patch > > and let MAINTAINER have time to response (or use maintainer timeout > > after two weeks)? > > If I have misinterpreted the blanket and if commits like this are > indeed not covered by it, I would rather refrain from making commits > like this in the future because I will not cause extra work for > myself and file PRs for these trivial fixes. That is asking way > too much. I can understand what you think. I neither support or discourage you from doing so. In fact, I'm very appreciative of you doing these work, just being a bit worried that this might be too aggressive and I'm afraid that it might cause conflicts (hope not). Just sending a mail to check with you from a friend's perspective. And yeah, there should be more handy tools for working on patch and PR. > > BTW, what's "porscan"? I didn't notice that tool. Sounds useful and > > can you tell me more about it? > > It's part of ports-mgmt/portfmt and will flag stuff like you see > here. I run it regularly and results are published here: > https://pkg.tobik.me/portscan/ Thanks for the information, that looks very useful. Li-Wen