From owner-freebsd-current  Fri Jan  8 00:18:41 1999
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Received: (from majordom@localhost)
          by hub.freebsd.org (8.8.8/8.8.8) id AAA21001
          for freebsd-current-outgoing; Fri, 8 Jan 1999 00:18:41 -0800 (PST)
          (envelope-from owner-freebsd-current@FreeBSD.ORG)
Received: from lamb.sas.com (lamb.sas.com [192.35.83.8])
          by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id AAA20985;
          Fri, 8 Jan 1999 00:18:38 -0800 (PST)
          (envelope-from jwd@unx.sas.com)
Received: from mozart (mozart.unx.sas.com [192.58.184.8])
	by lamb.sas.com (8.9.1/8.9.1) with SMTP id DAA25151;
	Fri, 8 Jan 1999 03:18:08 -0500 (EST)
Received: from bb01f39.unx.sas.com by mozart (5.65c/SAS/Domains/5-6-90)
	id AA04714; Fri, 8 Jan 1999 03:18:08 -0500
Received: (from jwd@localhost)
	by bb01f39.unx.sas.com (8.9.1/8.9.1) id DAA33723;
	Fri, 8 Jan 1999 03:18:04 -0500 (EST)
	(envelope-from jwd)
From: "John W. DeBoskey" <jwd@unx.sas.com>
Message-Id: <199901080818.DAA33723@bb01f39.unx.sas.com>
Subject: Bug in make affecting release crunchs
To: freebsd-current@FreeBSD.ORG
Date: Fri, 8 Jan 1999 03:18:04 -0500 (EST)
Cc: jkh@zippy.cdrom.com, freebsd-bugs@FreeBSD.ORG
X-Mailer: ELM [version 2.4ME+ PL43 (25)]
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: owner-freebsd-current@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.ORG

Hi Folks, Jordan,

    I found the problem with the boot_crunch in make release..

    Basically, Parse_IsVar() in parse.c contains the following
code snippet:

        default:
#ifdef SUNSHCMD
            while (*opc != ':')
                if (--opc < line)
                    break;


   Well, this allows opc to end up pointing to the character
just prior to line... ie:  opc == 0807e2ff  line == 0807e300

   Then this code:

            if (strncmp(opc, ":sh", 3) == 0) {
                type = VAR_SHELL;
                *opc = '\0';
                break;  
            }
#endif


   ends up comparing true if that 1 character in front of the
variable line happens to be a ':' and we are trying to set the
variable named 'sh_SRCDIR'.  (What a bummer...)


   The simple fix (diff -u):

diff -u parse.c.orig parse.c
--- parse.c.orig        Sun May 31 02:23:33 1998
+++ parse.c     Fri Jan  8 03:05:23 1999
@@ -1412,8 +1412,10 @@
        default:
 #ifdef SUNSHCMD
            while (*opc != ':')
-               if (--opc < line)
+               if (--opc < line) {
+                   ++opc;
                    break;
+               }
 
            if (strncmp(opc, ":sh", 3) == 0) {
                type = VAR_SHELL;



   Would some nice committer please commit this?

Thanks!
John


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message