From owner-cvs-all@FreeBSD.ORG Wed Mar 26 10:51:52 2003 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4F14837B404; Wed, 26 Mar 2003 10:51:52 -0800 (PST) Received: from elvis.mu.org (elvis.mu.org [192.203.228.196]) by mx1.FreeBSD.org (Postfix) with ESMTP id B7E9343FCB; Wed, 26 Mar 2003 10:51:51 -0800 (PST) (envelope-from bright@elvis.mu.org) Received: by elvis.mu.org (Postfix, from userid 1192) id 9F4352ED3DA; Wed, 26 Mar 2003 10:51:51 -0800 (PST) Date: Wed, 26 Mar 2003 10:51:51 -0800 From: Alfred Perlstein To: Ian Dowse Message-ID: <20030326185151.GT48996@elvis.mu.org> References: <200303260146.h2Q1kBbE031907@repoman.freebsd.org> <200303261038.aa94448@salmon.maths.tcd.ie> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200303261038.aa94448@salmon.maths.tcd.ie> User-Agent: Mutt/1.4i X-Spam-Status: No, hits=-26.0 required=5.0 tests=IN_REP_TO,QUOTED_EMAIL_TEXT,REFERENCES,REPLY_WITH_QUOTES, USER_AGENT_MUTT autolearn=ham version=2.50 X-Spam-Level: X-Spam-Checker-Version: SpamAssassin 2.50 (1.173-2003-02-20-exp) cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/nfsclient nfs_socket.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 26 Mar 2003 18:51:53 -0000 * Ian Dowse [030326 02:38] wrote: > In message <200303260146.h2Q1kBbE031907@repoman.freebsd.org>, Alfred Perlstein > writes: > > Modified files: > > sys/nfsclient nfs_socket.c > > Log: > > req can not be NULL or we'd die. > > I think the NULL checks were left over from revision 1.50 of > nfs_socket.c and then later extended (by me). Before 1.50, nfs_sndlock() > could be called with req == NULL, but the tests can safely be removed > now as you have done. Yah, doing work on another derived NFS implementation and felt like moving some obvious changes back into the base. -Alfred