From owner-svn-src-all@FreeBSD.ORG Fri Mar 18 14:02:38 2011 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 4A25D106564A; Fri, 18 Mar 2011 14:02:38 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from cyrus.watson.org (cyrus.watson.org [65.122.17.42]) by mx1.freebsd.org (Postfix) with ESMTP id 226248FC0C; Fri, 18 Mar 2011 14:02:38 +0000 (UTC) Received: from bigwig.baldwin.cx (66.111.2.69.static.nyinternet.net [66.111.2.69]) by cyrus.watson.org (Postfix) with ESMTPSA id AE0F246B5C; Fri, 18 Mar 2011 10:02:37 -0400 (EDT) Received: from jhbbsd.localnet (unknown [209.249.190.124]) by bigwig.baldwin.cx (Postfix) with ESMTPSA id 4B3D18A01B; Fri, 18 Mar 2011 10:02:37 -0400 (EDT) From: John Baldwin To: Nathan Whitehorn Date: Fri, 18 Mar 2011 10:02:29 -0400 User-Agent: KMail/1.13.5 (FreeBSD/7.4-CBSD-20110107; KDE/4.4.5; amd64; ; ) References: <201103181213.p2ICD4Vr066256@svn.freebsd.org> <4D83549C.5010703@freebsd.org> In-Reply-To: <4D83549C.5010703@freebsd.org> MIME-Version: 1.0 Message-Id: <201103181002.29638.jhb@freebsd.org> Content-Type: Text/Plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.6 (bigwig.baldwin.cx); Fri, 18 Mar 2011 10:02:37 -0400 (EDT) Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r219737 - head/sys/dev/pci X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 18 Mar 2011 14:02:38 -0000 On Friday, March 18, 2011 8:48:28 am Nathan Whitehorn wrote: > On 03/18/11 07:13, John Baldwin wrote: > > Author: jhb > > Date: Fri Mar 18 12:13:04 2011 > > New Revision: 219737 > > URL: http://svn.freebsd.org/changeset/base/219737 > > > > Log: > > Fix a few issues with HyperTransport devices and MSI interrupts: > > - Always enable the HyperTransport MSI mapping window for HyperTransport > > to PCI bridges (these show up as HyperTransport slave devices). > > The mapping windows in PCI-PCI bridges are enabled by existing code > > in the PCI-PCI bridge driver as MSI requests propagate up the device > > tree, but Host-PCI bridges don't really show up in that tree. > > - If the PCI device at domain 0 bus 0 slot 0 function 0 is not a > > HyperTransport device, then blacklist MSI on any other HT devices in > > the system. Linux has a similar quirk. > > > > I think this last change only works on x86 systems. My powerpc desktop > has hypertransport and MSI, but PCI bus 0 (the PCI-E bus with the > graphics card in it) is not connected over hypertransport and has > nothing to do with it. Also, the root host->HT bridge doesn't show up in > PCI space at all. Hmm, that is likely true. Rereading the Linux code, this last quirk only applies to Nvidia chipsets. Bah, I also botched it, so I'll remove that part for now. Only the first fix was needed for the PR. -- John Baldwin