From owner-svn-src-head@freebsd.org Sat Nov 14 19:46:49 2020 Return-Path: Delivered-To: svn-src-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 94A3F46450A for ; Sat, 14 Nov 2020 19:46:49 +0000 (UTC) (envelope-from jrtc27@jrtc27.com) Received: from mail-wr1-f46.google.com (mail-wr1-f46.google.com [209.85.221.46]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4CYQp13kH9z3sWQ for ; Sat, 14 Nov 2020 19:46:49 +0000 (UTC) (envelope-from jrtc27@jrtc27.com) Received: by mail-wr1-f46.google.com with SMTP id p1so14041560wrf.12 for ; Sat, 14 Nov 2020 11:46:49 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=TeNoyh/2104eFInfXfDmq5j3kbbfh06nP0nExtIvrwg=; b=dg6sKvECutpVaZvBAAk0LwHwQf8rsO0JKdugUG7EIr1x1slp/r7tUuwcf/wFfqQ/YY RTI59WJK9lzPcvUFN3gP/Q5S6S0VXQeKJ7FfiHaUYq2FFloKIy+i1lgyDRQaIbwkplXL xhY0kWQ1VClRs28gY17e/8XVGD87v0U2TOl9zcARtWXZ7BzJYVHrjRhEyaCcof24mkl2 8hqRCqtObKq+csjZOAem/vAZdmeYOgu/ixuhYII4dbITCWOEwrud6uP3Y+fik0j4JREH zKdsjW/+Ip1lSg7LqbSGXFqY+fxVGcJQ1JFFbdKUtqx539EQGT+5+o4zBQVTi2EUyMy0 D9YA== X-Gm-Message-State: AOAM531bXrNH/gcW/23GNNJiHIdSxLD8NnFjitjbZe/LEIXAjWw/eE3c UwaYYNFHUkHx+RBPv4Fp7nOT+g== X-Google-Smtp-Source: ABdhPJyfboKt6QBFzs88UzFxB0M0QfvSX8gFjnDjClf0gfUlhQ7e1fFYIyB9UPYKw31ART8C0wgvrQ== X-Received: by 2002:adf:bb92:: with SMTP id q18mr10667756wrg.315.1605383207848; Sat, 14 Nov 2020 11:46:47 -0800 (PST) Received: from [192.168.149.251] (trinity-students-nat.trin.cam.ac.uk. [131.111.193.104]) by smtp.gmail.com with ESMTPSA id q16sm15992287wrn.13.2020.11.14.11.46.46 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sat, 14 Nov 2020 11:46:46 -0800 (PST) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.120.23.2.4\)) Subject: Re: svn commit: r367689 - head/lib/libutil From: Jessica Clarke In-Reply-To: <202011141904.0AEJ4bXA043999@repo.freebsd.org> Date: Sat, 14 Nov 2020 19:46:45 +0000 Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Transfer-Encoding: 7bit Message-Id: References: <202011141904.0AEJ4bXA043999@repo.freebsd.org> To: Scott Long X-Mailer: Apple Mail (2.3608.120.23.2.4) X-Rspamd-Queue-Id: 4CYQp13kH9z3sWQ X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 14 Nov 2020 19:46:49 -0000 On 14 Nov 2020, at 19:04, Scott Long wrote: > @@ -66,10 +67,16 @@ getlocalbase(char *path, size_t pathlen) > #endif > > tmplen = strlcpy(path, tmppath, pathlen); > - if ((tmplen < 0) || (tmplen >= (ssize_t)pathlen)) { > + if ((tmplen < 0) || (tmplen >= pathlen)) { I'd expect the LHS to give a compiler warning still. Jess