From owner-svn-src-head@FreeBSD.ORG Sat Jan 9 18:14:35 2010 Return-Path: Delivered-To: svn-src-head@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 9D2FC106568B; Sat, 9 Jan 2010 18:14:35 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from harmony.bsdimp.com (bsdimp.com [199.45.160.85]) by mx1.freebsd.org (Postfix) with ESMTP id 411388FC14; Sat, 9 Jan 2010 18:14:35 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by harmony.bsdimp.com (8.14.3/8.14.1) with ESMTP id o09I79cD023114; Sat, 9 Jan 2010 11:07:09 -0700 (MST) (envelope-from imp@bsdimp.com) Date: Sat, 09 Jan 2010 11:07:58 -0700 (MST) Message-Id: <20100109.110758.29593248145802975.imp@bsdimp.com> To: bz@FreeBSD.org From: "M. Warner Losh" In-Reply-To: <20100109173314.V50938@maildrop.int.zabbadoz.net> References: <20100110.001429.173527971.nyan@FreeBSD.org> <20100109.100512.623571555980925615.imp@bsdimp.com> <20100109173314.V50938@maildrop.int.zabbadoz.net> X-Mailer: Mew version 6.3 on Emacs 22.3 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org, nyan@FreeBSD.org Subject: Re: svn commit: r201815 - head X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 09 Jan 2010 18:14:35 -0000 In message: <20100109173314.V50938@maildrop.int.zabbadoz.net> "Bjoern A. Zeeb" writes: : On Sat, 9 Jan 2010, M. Warner Losh wrote: : : > In message: <20100110.001429.173527971.nyan@FreeBSD.org> : > TAKAHASHI Yoshihiro writes: : > : In article <201001081901.o08J1pjc062909@svn.freebsd.org> : > : "Bjoern A. Zeeb" writes: : > : : > : > To avoid hardcoding further kernel configuration names for : > : > make universe, split the logic into two parts: : > : > - 1st to build worlds and generate kernel configs like LINT. : > : > - 2nd to build kernels for a given TARGET architecture correctly : > : > finding all newly generated configs, not knowing anything about : > : > LINT anymore. (*) : > : : > : > +universe_kernels: universe_kernconfs : > : > +BUILD_ARCH!= uname -p : > : : > : Should this be "uname -m"? : > : : > : : > : > +TARGET?= ${BUILD_ARCH} : > : > +KERNCONFS!= cd ${.CURDIR}/sys/${TARGET}/conf && \ : > : > + find [A-Z0-9]*[A-Z0-9] -type f -maxdepth 0 \ : > : > + ! -name DEFAULTS ! -name NOTES : > : > Yes. Also, the name BUILD_ARCH is misleading, since it corresponds to : > MACHINE, not to MACHINE_ARCH. it is clear that it is used in the : > MACHINE context, not the MACHINE_ARCH context. : > : > These two are often confused, but many of the embedded platforms have : > added to the confusion and it is unclear where the sharp dividing line : > should be here anymore. It used to be separate boot environment, but : > even that has gotten fuzzy for architectures like mips and arm that : > boot with a huge variety of boot loaders... : : I guess the intial problem I had it from was introduced in r54311 to : Makefile.inc1, which nowadays reads like: : : BUILD_ARCH!= uname -p : : : So, the suggested correction would be: : : MACHINE!= uname -m : : I wonder if I should use XMACHINE but that usually means : "cross"(building). I could use _MACHINE!= to not confuse it with : MACHINE from Makefile.inc1? XMACHINE might be best. MACHINE and MACHINE_ARCH are really magic and special and shouldn't ever be set (well, almost never). Warner