From owner-svn-src-head@freebsd.org Sat Oct 7 16:29:40 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 8F0FCE3BC7D; Sat, 7 Oct 2017 16:29:40 +0000 (UTC) (envelope-from guyyur@gmail.com) Received: from mail-wm0-x241.google.com (mail-wm0-x241.google.com [IPv6:2a00:1450:400c:c09::241]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id EA3468226F; Sat, 7 Oct 2017 16:29:39 +0000 (UTC) (envelope-from guyyur@gmail.com) Received: by mail-wm0-x241.google.com with SMTP id q132so13930591wmd.2; Sat, 07 Oct 2017 09:29:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=pn1k5UQcBdW+DkvmPijs0gWcjpUBxFdvuvAldWZgL5c=; b=D9RlLjX85gpF0n4J7VL8xRPpYKEn5sIuA3DHZ9VYRZoDCYr34ZrcNfuCHs6LMLiiKT vWwy3UTTLV8/XOHRHB62OeQeSCJQZws9mZYpK0mAs5R9h/Y26D5T2AzM3i8p3ItF4LHu UU19WIUgqEIIanKpSeVWW4KSp9olTMoaxsZikouiaOel0jyn8vPOXKqLXrI44a8avISK U2L/WSnGH9K1wz+2xpz0MpK3ZW9uqZ2EgWPDv0SDWlNWRMWrIP04QTyPCFAGoMM5IFmL z7308rucGqkQO+LwERVP8wdl/IiHw3q9fUdbrMrpoJUzZVv9u6dnlIvkVIBTMU3pmvlv c3Jg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=pn1k5UQcBdW+DkvmPijs0gWcjpUBxFdvuvAldWZgL5c=; b=WNe0c+cuWeNFAipM8kxyfp9w/NF6y+45JsghC/+wbEw6QzaLU8DQgnnEQK3J3iNx0O 9bgJHl1V8TsThgjs6FNCxfkJBdXTQ2K9t5XAFFMVfqMBzWQ2jaTK/40heS92vrvNamWs OzS9XlnP1jOgpGQ0CdrlfLERs6cvSOCxhPF64WWXjvUIM+TeM9dBQmmzdV2oEVZl2qKV Wn36xlPagDYs+203xn/+rtlGbpsbfuDMEOLduNTvAViwrmxmELSEDfhhRG0Nml4nGddM VJ11rJRCvrdQHvtCblyw09FpIg2kmsrKkpwpIdf7SORJJxO5PF2Jzxjg3cM6bvXucJvj 5E3w== X-Gm-Message-State: AMCzsaXggFIAqKkDDYzlnIS9T5Nl8V3a14NWQZws+v/T+ljxZI3B5O2d aiO3YTqyy782uWxlQMYghLIpXtEbFJevup+KsGtO1A== X-Google-Smtp-Source: AOwi7QCHqUt2LUU3+q0CVg2T92nb2sVQbhom+yjNUbCdNgW4E2znCDqoQBZ2nc+gqo1snMygL+cdWx99tQ9bIdY8oXc= X-Received: by 10.28.11.133 with SMTP id 127mr3941739wml.81.1507393778225; Sat, 07 Oct 2017 09:29:38 -0700 (PDT) MIME-Version: 1.0 Received: by 10.28.197.141 with HTTP; Sat, 7 Oct 2017 09:29:37 -0700 (PDT) In-Reply-To: <201710061221.v96CLko0046237@repo.freebsd.org> References: <201710061221.v96CLko0046237@repo.freebsd.org> From: Guy Yur Date: Sat, 7 Oct 2017 19:29:37 +0300 Message-ID: Subject: Re: svn commit: r324360 - in head/sys/boot/efi: include libefi loader To: Warner Losh Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset="UTF-8" X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 07 Oct 2017 16:29:40 -0000 On 6 October 2017 at 15:21, Warner Losh wrote: > Author: imp > Date: Fri Oct 6 12:21:46 2017 > New Revision: 324360 > URL: https://svnweb.freebsd.org/changeset/base/324360 > > Log: > Encapsulate ZFS preferences into efi_zfs_is_preferred > > Move the retrieval of the image information into loader's main instead > of doing it in efizfs.c > > Differential Revision: https://reviews.freebsd.org/D12564 > Submitted by: Eric McCorkle > > Modified: > head/sys/boot/efi/include/efizfs.h > head/sys/boot/efi/libefi/efizfs.c > head/sys/boot/efi/loader/main.c > > ... > _______________________________________________ > svn-src-head@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/svn-src-head > To unsubscribe, send any mail to "svn-src-head-unsubscribe@freebsd.org" Hi, When setting WITHOUT_ZFS in src.conf the build fails with: /usr/src/sys/boot/efi/loader/main.c:78:1: error: no previous prototype for function 'efi_zfs_is_preferred' [-Werror,-Wmissing-prototypes] efi_zfs_is_preferred(EFI_HANDLE *h) ^ 1 error generated. *** Error code 1 The prototype is under #ifdef EFI_ZFS_BOOT guard but the function is not. Thanks, Guy