From nobody Thu Dec 18 18:23:11 2025 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4dXJv415Cdz6LV7P for ; Thu, 18 Dec 2025 18:23:12 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R12" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4dXJv35YgHz47VC for ; Thu, 18 Dec 2025 18:23:11 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1766082191; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=iWEDBTly3bW3aFVYod/OOGJgAksBczVpLr/lhF29du4=; b=yvUKsmNtbqIp5Q/ROwIQGBLpfVkfoXjC6AnNIWe2Bk3fdzftECSyCCMDAmiBudKo0ocN3x ygU/P4Soh+Tu3MW+JcrtzNr91DR6cCAlWRi0D/lXFr6F7ZEGNApx6MUqV+qWNx6U0xG26E BOeeIQEYd4MoLBp4PVrRY9lVgqD1iOVFP9RAb64CkFL5vBgOXpQ//B+TOkx+2ICMv3NZux WYGGI1v04DBA87opLtX6ohwOyNESN2993eW3tHBp8DvsssgjpaD74M7mmZ9wbO9zoLTOza DzpLKQY7vryXfxSzZUHAlu/6WtkjaUWkpaAy9ThZAfeBhBdvs+jtQwwHMDYVaA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1766082191; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=iWEDBTly3bW3aFVYod/OOGJgAksBczVpLr/lhF29du4=; b=fuXmGR9Qa8l+vNfUTWjfDa4qObj5Iq+yElLW5zEzvpuP+QTYmWtlmrO+pZ24QacieVngkB 0FUUFM6yqXIyL5NTFxfiynQ9IAmsP73ltRCSRYI1LqDDHFr8jBV5JFcvfffrxpv71rp4ol IrVB4QOzVRI+6DwFrfhdUonMO79mMO/Cbj0LyURJMnyWFSKTRgiJZdVpj+xOVmWjwhVaNo T36gRD5WASrneVN3Jt4CUWbO5tLn3tHiMVeG3AEagoCODpgYOGrpd1pPNdkQk3o0S5MFsM KzEwc5CDehrRpoq0HkdEh51hSd1t9mNZaSMxWsN2WRdX+G5UlahtU4WMTXlEwQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1766082191; a=rsa-sha256; cv=none; b=ADg9nhYI4P32PHDX74v34KVUnSLJumdX1CNQqXxzV1kWjEQ07SEWsHIPVuyB0yyv9H4TSA Ne1qjvex+HVs62u/go45alM/VPMsPe+QAZYX//XB45meMn8f1lKB/lMEmtZGShlItMgNB1 FtGIesHA+WhHhYXbTcHxuN94LTe0l4woEYt9wXVFLhOlsV9K0Btv/q8AUAkdM/ddMjayCs +rYEKcyH+nzW1tbA68E/ZuW+YQwx7tHF+9hDsArQiQr6og9gteDzWhOXzoxXOcSOChA1qR T7GMoOgwNcELbd3YIx/JxihV4bidkm3OwjLsayyR20eIW1RZ9E+jtEJG7ALKPg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4dXJv34pWbzqS5 for ; Thu, 18 Dec 2025 18:23:11 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 24461 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Thu, 18 Dec 2025 18:23:11 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org Cc: Konstantin Belousov From: John Baldwin Subject: git: 7bf3b6d8e426 - stable/14 - fcntl(F_SETFL): only allow one thread to perform F_SETFL List-Id: Commits to the stable branches of the FreeBSD src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-branches@freebsd.org Sender: owner-dev-commits-src-branches@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: jhb X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: 7bf3b6d8e4263d63f4276b27035f2c6254c28a86 Auto-Submitted: auto-generated Date: Thu, 18 Dec 2025 18:23:11 +0000 Message-Id: <6944468f.24461.76f18959@gitrepo.freebsd.org> The branch stable/14 has been updated by jhb: URL: https://cgit.FreeBSD.org/src/commit/?id=7bf3b6d8e4263d63f4276b27035f2c6254c28a86 commit 7bf3b6d8e4263d63f4276b27035f2c6254c28a86 Author: Konstantin Belousov AuthorDate: 2025-09-11 10:05:04 +0000 Commit: John Baldwin CommitDate: 2025-12-18 17:01:56 +0000 fcntl(F_SETFL): only allow one thread to perform F_SETFL Use f_vflags file locking for this. Allowing more than one thread handling F_SETFL might cause de-sync between real driver state and flags. Reviewed by: markj Tested by: pho Sponsored by: The FreeBSD Foundation MFC after: 2 weeks Differential revision: https://reviews.freebsd.org/D52487 (cherry picked from commit 4c3a868d13c053ef173268cdfe1365978a282178) --- sys/kern/kern_descrip.c | 3 +++ sys/kern/vfs_vnops.c | 36 ++++++++++++++++++++++++++++++++++++ sys/sys/file.h | 4 ++++ 3 files changed, 43 insertions(+) diff --git a/sys/kern/kern_descrip.c b/sys/kern/kern_descrip.c index e8bbc5d9ee1c..51752aa8ab33 100644 --- a/sys/kern/kern_descrip.c +++ b/sys/kern/kern_descrip.c @@ -571,6 +571,7 @@ kern_fcntl(struct thread *td, int fd, int cmd, intptr_t arg) error = EBADF; break; } + fsetfl_lock(fp); do { tmp = flg = fp->f_flag; tmp &= ~FCNTLFLAGS; @@ -590,6 +591,7 @@ kern_fcntl(struct thread *td, int fd, int cmd, intptr_t arg) if (error != 0) goto revert_nonblock; } + fsetfl_unlock(fp); fdrop(fp, td); break; revert_nonblock: @@ -604,6 +606,7 @@ revert_flags: tmp |= got_cleared; tmp &= ~got_set; } while (atomic_cmpset_int(&fp->f_flag, flg, tmp) == 0); + fsetfl_unlock(fp); fdrop(fp, td); break; diff --git a/sys/kern/vfs_vnops.c b/sys/kern/vfs_vnops.c index 4d1df41cf588..ee247de2374c 100644 --- a/sys/kern/vfs_vnops.c +++ b/sys/kern/vfs_vnops.c @@ -863,6 +863,18 @@ foffset_read(struct file *fp) return (atomic_load_long(&fp->f_offset)); } +void +fsetfl_lock(struct file *fp) +{ + file_v_lock(fp, FILE_V_SETFL_LOCKED, FILE_V_SETFL_LOCK_WAITING); +} + +void +fsetfl_unlock(struct file *fp) +{ + file_v_unlock(fp, FILE_V_SETFL_LOCKED, FILE_V_SETFL_LOCK_WAITING); +} + #else /* OFF_MAX <= LONG_MAX */ static void @@ -938,6 +950,30 @@ foffset_read(struct file *fp) return (foffset_lock(fp, FOF_NOLOCK)); } + +void +fsetfl_lock(struct file *fp) +{ + struct mtx *mtxp; + + mtxp = mtx_pool_find(mtxpool_sleep, fp); + mtx_lock(mtxp); + file_v_lock_mtxp(fp, mtxp, FILE_V_SETFL_LOCKED, + FILE_V_SETFL_LOCK_WAITING); + mtx_unlock(mtxp); +} + +void +fsetfl_unlock(struct file *fp) +{ + struct mtx *mtxp; + + mtxp = mtx_pool_find(mtxpool_sleep, fp); + mtx_lock(mtxp); + file_v_unlock_mtxp(fp, mtxp, FILE_V_SETFL_LOCKED, + FILE_V_SETFL_LOCK_WAITING); + mtx_unlock(mtxp); +} #endif void diff --git a/sys/sys/file.h b/sys/sys/file.h index 349605939d30..785230160b69 100644 --- a/sys/sys/file.h +++ b/sys/sys/file.h @@ -90,6 +90,8 @@ void foffset_lock_pair(struct file *fp1, off_t *off1p, struct file *fp2, void foffset_lock_uio(struct file *fp, struct uio *uio, int flags); void foffset_unlock(struct file *fp, off_t val, int flags); void foffset_unlock_uio(struct file *fp, struct uio *uio, int flags); +void fsetfl_lock(struct file *fp); +void fsetfl_unlock(struct file *fp); static inline off_t foffset_get(struct file *fp) @@ -219,6 +221,8 @@ struct file { #define FILE_V_FOFFSET_LOCKED 0x0001 #define FILE_V_FOFFSET_LOCK_WAITING 0x0002 +#define FILE_V_SETFL_LOCKED 0x0004 +#define FILE_V_SETFL_LOCK_WAITING 0x0008 #endif /* __BSD_VISIBLE */ #endif /* _KERNEL || _WANT_FILE */