From owner-freebsd-ports-bugs@FreeBSD.ORG Tue Nov 1 15:30:23 2005 Return-Path: X-Original-To: freebsd-ports-bugs@hub.freebsd.org Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 6881016A420 for ; Tue, 1 Nov 2005 15:30:23 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3394143D46 for ; Tue, 1 Nov 2005 15:30:23 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.13.3/8.13.3) with ESMTP id jA1FUNik005517 for ; Tue, 1 Nov 2005 15:30:23 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.13.3/8.13.1/Submit) id jA1FUNj0005516; Tue, 1 Nov 2005 15:30:23 GMT (envelope-from gnats) Date: Tue, 1 Nov 2005 15:30:23 GMT Message-Id: <200511011530.jA1FUNj0005516@freefall.freebsd.org> To: freebsd-ports-bugs@FreeBSD.org From: NIIMI Satoshi Cc: Subject: Re: ports/87416: [PATCH] adapt lang/sbcl to PREFIX other than /usr/local X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: NIIMI Satoshi List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 Nov 2005 15:30:23 -0000 The following reply was made to PR ports/87416; it has been noted by GNATS. From: NIIMI Satoshi To: bug-followup@FreeBSD.org, MOROHOSHI Akihiko , Paul Ledbetter III Cc: Subject: Re: ports/87416: [PATCH] adapt lang/sbcl to PREFIX other than /usr/local Date: Wed, 02 Nov 2005 00:25:35 +0900 This is a multi-part message in MIME format. --------------000709020001060707020906 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Basically I agree MOROHOSHI Akihiko that installed binary should respect PREFIX variable. But I also agree Paul Ledbetter III that the original patch is not acceptable. How about to locate attached patch in files/ to make ${WRKSRC}/make.sh accept INSTALL_ROOT like ${WRKSRC}/install.sh, and to change Makefile as: > do-build: > - (cd ${WRKSRC} && ${SH} make.sh ${LISP_CMD}) > + (cd ${WRKSRC} && ${SETENV} INSTALL_ROOT=${PREFIX} \ > + ${SH} make.sh ${LISP_CMD}) Although this change does not modify "/usr/local" in documents, I think it is not so important. -- NIIMI Satoshi --------------000709020001060707020906 Content-Type: text/plain; name="patch-src_runtime_GNUmakefile" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="patch-src_runtime_GNUmakefile" Index: src/runtime/GNUmakefile =================================================================== RCS file: /cvsroot/sbcl/sbcl/src/runtime/GNUmakefile,v retrieving revision 1.24 diff -u -r1.24 GNUmakefile --- src/runtime/GNUmakefile 19 Aug 2005 12:15:15 -0000 1.24 +++ src/runtime/GNUmakefile 1 Nov 2005 14:46:55 -0000 @@ -22,7 +22,10 @@ DEPEND_FLAGS = -MM GREP = grep -CFLAGS = -g -Wall -O3 +ifeq ($(strip $(INSTALL_ROOT)),) +INSTALL_ROOT = /usr/local +endif +CFLAGS = -g -Wall -O3 -DSBCL_HOME=\"$(INSTALL_ROOT)/lib/sbcl/\" ASFLAGS = $(CFLAGS) CPPFLAGS = -I. --------------000709020001060707020906--