Date: Sun, 08 Jul 2007 16:55:44 -0700 From: Doug Barton <dougb@FreeBSD.org> To: Edward Tomasz Napierala <trasz@FreeBSD.org> Cc: cvs-ports@FreeBSD.org, Martin Wilke <miwi@FreeBSD.org>, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/audio/oss Makefile ports/audio/oss/files oss.in pkg-message.in Message-ID: <46917980.5080105@FreeBSD.org> In-Reply-To: <200707081232.l68CWDqv084906@repoman.freebsd.org> References: <200707081232.l68CWDqv084906@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Edward Tomasz Napierala wrote: > trasz 2007-07-08 12:32:13 UTC > > FreeBSD ports repository > > Modified files: > audio/oss Makefile > audio/oss/files oss.in pkg-message.in > Log: > - Fix rc script to not emit a warning at startup when oss_enable is not > set in /etc/rc.conf, > http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/audio/oss/files/oss.in.diff?&r1=1.1&r2=1.2&f=h You have the right idea, but the wrong fix. :) You want to use: : ${oss_enable=NO} and you want to do it after load_rc_config. Take a look at http://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/rc-scripts.html for more information. Two other things that seem odd to me, why is there a - at the end of the shebang line, and why does this script REQUIRE: cleanvar? I would think that DAEMON would be a better choice, but if there is a good reason for it to run that early, that's fine. I just want to be sure that it's been thought through. Thanks, Doug -- This .signature sanitized for your protection
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?46917980.5080105>