From nobody Tue Jan 21 16:02:48 2025 X-Original-To: net@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4YcsRr424gz5lGn6 for ; Tue, 21 Jan 2025 16:02:48 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4YcsRr3PSkz3GNL for ; Tue, 21 Jan 2025 16:02:48 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1737475368; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=IMpRelAg51MqvaXU7Y48sZxd0oTn9URUB3p6MYvyJwY=; b=KIiENO0PdsdOaIy0mmUOCqcaVR99Ve6qys3PABDGEBtTV1BqgP1VpOwDdNZfb10cTeNI0H tK//NjRCkMiXBgfiEWr51lWMrZ3y93+Z23OItgv3lafYrFzAwsJ0K3TXax1brUB00HGX1z XMpC0fEgAKzV7CPedUF3HMDsZ6SBC6zm2rXCRiyd0cc7DVtTFJ9OmENxxd06Tin4UWUEyo L9ojMjMzpSi2eFMUX4s/eAamPRiAdeqV3X2LmFewvKSEOCLb8SOQl2H2lSe1vVEN+7lT0b dfbkcCIGc6Nvk98RqGJWo5T2cXLc3sLDQ62h5C3r2J9IZLq7D88UgU5SGpHiOw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1737475368; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=IMpRelAg51MqvaXU7Y48sZxd0oTn9URUB3p6MYvyJwY=; b=OEn6xbc5dK/fQJKg40gdJI+SrmLv5iJjoHLlTfjWRUPwz+kfuJjsaA0qC+SYvQkLGBchYy 3H7ZSmbRxEbtvgjbe0cGbrV5dm8sNh3RGqe+5fl9OQuk6di8+fbCN8uyYvgK24W1rIzhW8 sDr5h65oABAgOxukc5NLL87EtVuyLUahXHuMnnBr2491jukSmmr0ozS4zDSvhSEF1g17eN pAOUThf7VFu/U0E7ewuHZf5q+K2a84kwypaTWoazxhbwV7vlsiqAYTkkopbi7TQ51upsZw P+OwR9nCIDIsR3owoMh5Dbvhh0UpSyAQHQtmUP4pt3UGon5BddjZlVGVzwvnuw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1737475368; a=rsa-sha256; cv=none; b=ay4geTPKfw2bYkWCAhS8eTtTyFQvHZKx7GPQHGt40wdhSqfJZuWnu5nmsmG6pXtjUI4npe fec7ARv0ttAhMsLHL84Gsu306NX1Yq0fKIvCNj4giYeo/cIXou3iFOwYoHNWDwnoLax5Tp KBcytN/AVibM9xroou/0quB5NjefzfXuYRJ0ZreFHYKwpXuQMKyyu8fLP7QFvGnlhwThCL y3vzM9NR/X49eH57miI3jhCmaYQbEps7lXX29x0hb5phLvh5Yp8t/zD2pVFz9Q/hyTAD8Q SgM99YjPwbT9OACLjw9x2NXuLMBxS18yVoGNGatF9V6BE1jXyjjpzP190awH4g== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4YcsRr2x3Mz1Ckp for ; Tue, 21 Jan 2025 16:02:48 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 50LG2mZM001889 for ; Tue, 21 Jan 2025 16:02:48 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 50LG2m4L001887 for net@FreeBSD.org; Tue, 21 Jan 2025 16:02:48 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: net@FreeBSD.org Subject: [Bug 284057] vmxnet3/iflib: crash in vmxnet3_isc_txd_credits_update Date: Tue, 21 Jan 2025 16:02:48 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 13.3-RELEASE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: avg@FreeBSD.org X-Bugzilla-Status: Open X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: net@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Networking and TCP/IP with FreeBSD List-Archive: https://lists.freebsd.org/archives/freebsd-net List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-net@FreeBSD.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D284057 --- Comment #12 from Andriy Gapon --- Another thing. There is a curious comment in vmxnet3_msix_intr_assign which I cannot really understand: /* * Don't provide the corresponding rxq irq for reference - * we want the transmit task to be attached to a task queue * that is different from the one used by the corresponding * rxq irq. That is because the TX doorbell writes are very * expensive as virtualized MMIO operations, so we want to * be able to defer them to another core when possible so * that they don't steal receive processing cycles during * stack turnarounds like TCP ACK generation. The other * piece to this approach is enabling the iflib abdicate * option (currently via an interface-specific * tunable/sysctl). */ Just out of curiosity I set dev.vmx.0.iflib.tx_abdicate=3D1. Since doing that I do not see any concurrent calls to vmxnet3_isc_txd_credits_update for the same queue. That is, each queue is always handled on its own CPU. Used this for checking: dtrace -n 'vmxnet3_isc_txd_credits_update:entry /args[1] !=3D curthread->td_oncpu/ { @[stack()] =3D count(); }' --=20 You are receiving this mail because: You are the assignee for the bug.=