From owner-cvs-all@FreeBSD.ORG Sun May 1 04:45:37 2011 Return-Path: Delivered-To: cvs-all@FreeBSD.org Received: from chateau.d.if (localhost [IPv6:::1]) by hub.freebsd.org (Postfix) with ESMTP id 6DD93106566B; Sun, 1 May 2011 04:45:36 +0000 (UTC) (envelope-from ashish@freebsd.org) Received: from chateau.d.if (chateau.d.if [IPv6:::1]) by chateau.d.if (Postfix) with ESMTP id A34AE4560E; Sun, 1 May 2011 10:15:34 +0530 (IST) From: ashish@freebsd.org (Ashish SHUKLA) To: Pan Tsu Organization: The FreeBSD Project References: <201104281508.p3SF8PjS068074@repoman.freebsd.org> <86tydfnbem.fsf@gmail.com> <86pqo3mhbu.fsf@chateau.d.if> <86iptv15zc.fsf@gmail.com> X-Face: )vGQ9yK7Y$Flebu1C>(B\gYBm)[$zfKM+p&TT[[JWl6:]S>cc$%-z7-`46Zf0B*syL.C]oCq[upTG~zuS0.$"_%)|Q@$hA=9{3l{%u^h3jJ^Zl; t7 X-Uptime: 10:04AM up 8 hrs, 9 users, load averages: 0.12, 0.12, 0.08 X-URL: http://people.freebsd.org/~ashish/ X-Operating-System: FreeBSD/FreeBSD 8.2-RELEASE/amd64 X-OpenPGP-Fingerprint: F682 CDCC 39DC 0FEA E116 20B6 C746 CFA9 E74F A4B0 X-Attribution: =?utf-8?B?4KSG4KS24KWA4KS3?= Organisation: The FreeBSD Project Date: Sun, 01 May 2011 10:15:29 +0530 In-Reply-To: <86iptv15zc.fsf@gmail.com> (Pan Tsu's message of "Sun, 1 May 2011 06:59:03 +0400") Message-ID: <8639kzhvva.fsf@chateau.d.if> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (amd64-portbld-freebsd8.2) Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAJ1BMVEWpqal/f39tbW1jY2Md HR2goKCenp6UlJROTk7////9/f35+fnT09ORJdieAAACVklEQVQ4jXXUP2vbQBQA8AvUTkgz5OzY Z0iGWhpS6BSrkECn0mvx0MEJ6AjtYrfoBCVDlD8naJYmNlRfwZq8+mkKlIZaGpJSYmP7Q/XkJDrJ Td8i/H68u3vHPaPufwLdf32AMA4A6GcAgvAamY1pOJiDIFqicTwLswDhfr3uxfFtkAY/GFHPMwzD 8zpnACmIOnE6js7rQb+v4NJrG9od0C+QgpHMy5jBewV+UDSMWiw1Y4fWfyV7+NGFzDsYa3pth9LJ Q4XvXxFHcJRvHOmygn5NAEabnDcQQguarnfoiwSCJ99jmKKcphsZONmWsDK9Ro7cvZOCtQdg8nje egLhc2LNlkLmsezzTFUUy5w18ocox/f0LaLgJy0zO75zk+9pp85GAj36xjqhdI0y3tq2m4dqqcWX zQWBTz8L1irvolXV4J+3q7eCDgVnttjNq6X8H+9KOZsuNk1uCzx8pSp+E9HImfJOTLdcGqo+YKnG EIovizkEn48V7BO+ch2DXcD4ENSpWiU+q8hjjbgTBZCXnZtyj0Ws4Q1Q0B2WXFtYZo65Bbyeeldw RS6qFueM80LlLA29YlVwGRYvFD+kwI/0O+A2PlpOP9GwslUVciHuYGechuBTp922YiDZCrghTknm XSyOM+D3aoRZlo0Jb42zY7DN4p2x4AeZ+QAYutx1sHwTHzMT5cMNduQ9yW3GczN4KZ86kb0c9O8T yXDeFqpl2fryPEAYGXIlezAPXYh2NgVr/gvdoHIuDwuPwOhcWE8f8mmICq41eATkn8x0kuRTIKcB wE9+/QUtiiAnYcaN7wAAAABJRU5ErkJggg== MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Cc: cvs-ports@FreeBSD.org, Ashish SHUKLA , cvs-all@FreeBSD.org, ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/editors/emacs-devel Makefile distinfo ports/editors/emacs-devel/files patch-Makefile.in patch-configure patch-configure.in patch-doc-emacs-Makefile.in patch-doc-lispintro-Makefile.in patch-doc-lispref-Makefile.in patch-doc-misc-Makefile.in patch-src_config.in X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: **OBSOLETE** CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 01 May 2011 04:45:37 -0000 --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Pan Tsu writes: > ashish@freebsd.org (Ashish SHUKLA) writes: >> Pan Tsu writes: >>> - Any reason to use autogen.sh instead of relying on AUTOTOOLS? >>=20 >> Because autogen.sh works fine, and is provided by the upstream to config= ure >> the sources. So, I prefer to use upstream, unless it behaves badly. > It makes sure autotools use and dependencies are tracked properly by the > ports framework. For example, autoreconf (from autogen.sh) invokes > autoheader which you did not specify in AUTOTOOLS. Although, at the moment, it's implicitly included as autoconf is also provi= ded by same package, but I guess explicitly mentioning it is better way. So, I'= ll append "autoheader:env" to USE_AUTOTOOLS, as well. >>> - Why patch-src_config.in was lost and not converted to patch-configure= .in? >>=20 >> As I see, in src/config.in (excerpt is pasted below) which get generated >> already includes "stdlib.h", so I don't see any need of the re-including= it, >> unless you think it causes some issue. > Including stdlib.h makes sure both alloca(3) and _STDLIB_H_ are defined > at that point and no prior or future explicit inclusion of stdlib.h > redefines it. The warning described ports/149049 is still present Sorry about this :(. Thanks for the explanations, and checks you carried ou= t. I'll include the changes and commit them. =2D-=20 Ashish SHUKLA | GPG: F682 CDCC 39DC 0FEA E116 20B6 C746 CFA9 E74F A4B0 freebsd.org!ashish | http://people.freebsd.org/~ashish/ Avoid Success At All Costs !! --=-=-= Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.16 (FreeBSD) iQIcBAEBCgAGBQJNvOVtAAoJEMdGz6nnT6Sw+0IQAJ050l7OTPpBs8JZAE7BF8UU e9ZwdBEAwR9qpYV7xc2EUu+/9qVDU63q0vQQvxHEhmmnaMIzME+4/i1aSSncQHBq CTHq3LiCyJHYJNYMwYkdaQ+fxrfbqT524UxStXVlufthDQ51s6cLLRlHH792r4Ei 9Ob/efy1hIjUARmloDLXpxnu8hbplWO8jPg0FMcv2mS1MosUY6QS9dXRY1yZg22D fUNPmZ2aaxHIh8sxaaASxsE/GAUbpaywgxN0IHuNPDP7MfEphEcj0mRad4SpO3fK to0eaPWsJBFDtkj5/d3oPs1McIzhVOs3UU6f06sYVWTmk5rRv5psMfLFiMeDMtTf thevmo+hxduPAqtqCQXN3sBPZwUq357/LkcVZUyksKXcj1j0ggmdkNfi+XfGzXIT E/qQvz/ZVz1kOdGcgbYxxOvkdigDdu4/IktOKr0i/YtfNvtPfa/KhXbjcjzZVCy0 UdKMXpdShjc0aAOQR6UqxIxD8fUotLTKxy+PD6b9QLOrRgz4W7WKHBUKYlpVkNjn kvlhshqfHkVCwsXtBkUsiFt/4sWnnvShaTeYf9Y429srGPVpMbPeu9jt72JUZes4 LhMVa6U2Q8p0EG/2RNu4OsU50eCjl1lxpk52dT1uLr2d3MsRwvmoCt3VkCOLjvEL 0V4z8nr08AREKnDiltRG =VHAt -----END PGP SIGNATURE----- --=-=-=--