From owner-cvs-src@FreeBSD.ORG  Sun Oct  5 01:12:12 2003
Return-Path: <owner-cvs-src@FreeBSD.ORG>
Delivered-To: cvs-src@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 3A90716A4B3; Sun,  5 Oct 2003 01:12:12 -0700 (PDT)
Received: from mail.chesapeake.net (chesapeake.net [208.142.252.6])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id D2C4444001; Sun,  5 Oct 2003 01:12:10 -0700 (PDT)
	(envelope-from jroberson@chesapeake.net)
Received: from localhost (jroberson@localhost)
	by mail.chesapeake.net (8.11.6/8.11.6) with ESMTP id h958CAM29658;
	Sun, 5 Oct 2003 04:12:10 -0400 (EDT)
	(envelope-from jroberson@chesapeake.net)
Date: Sun, 5 Oct 2003 04:12:10 -0400 (EDT)
From: Jeff Roberson <jroberson@chesapeake.net>
To: Don Lewis <truckman@FreeBSD.org>
In-Reply-To: <200310050742.h957gIN1048517@gw.catspoiler.org>
Message-ID: <20031005041049.L99666-100000@mail.chesapeake.net>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
cc: cvs-src@FreeBSD.org
cc: jeff@FreeBSD.org
cc: src-committers@FreeBSD.org
cc: cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sys/kern vfs_subr.c
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 05 Oct 2003 08:12:12 -0000

On Sun, 5 Oct 2003, Don Lewis wrote:

> On  5 Oct, Jeff Roberson wrote:
> > jeff        2003/10/05 00:12:38 PDT
> >
> >   FreeBSD src repository
> >
> >   Modified files:
> >     sys/kern             vfs_subr.c
> >   Log:
> >    - Fix an XXX.  Check the error of vn_lock() in vflush().  Don't specify
> >      LK_RETRY either, we don't want this vnode if it turns into another.
> >    - Remove the code that checks the mount point after acquiring the lock
> >      we are guaranteed to either fail or get the vnode that we wanted.
> >
> >   Revision  Changes    Path
> >   1.465     +2 -13     src/sys/kern/vfs_subr.c
>
> What keeps this from spinning if some other thread holds the lock on the
> first vnode on the list?
>

It should only fail if the vnode was vcleaned() out from under us, right?
If that's the case than the list has been modified by the time we relock
it and check.

Do you agree?

Thanks,
Jeff