From nobody Fri Jan 30 00:03:06 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4f2GRv1MPFz6QKGS for ; Fri, 30 Jan 2026 00:03:07 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R13" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4f2GRv0X9gz3HBM for ; Fri, 30 Jan 2026 00:03:07 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1769731387; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=ZrIY3qk+ea/lxc3L88rbPiX+Z0gXQLckml/pKJL2grM=; b=wh4zvDnPT5oI4rZSYh6qoIVXWlL5B6RfEQdQ/0AjfIzWzxEgkfQ2Ax09+ID11exsdrpgzD BFiw7/VTPbupS0ji7xzFY0m0KtFMRomu4C08YMeUSmzr7OR26tNmiXC7R78XxKgkJx9n7Q BPl2iz1awkLLTsTTNHAXtNLKPDJAOX3RlOUDVpdWqUs/m2CSsjoGfusTbUYu1/Vb7pfZDI YrKKdKK+s3cg+95LFUu4YwUhCfhWITyETQDDxnRvdtihYBtVxJ/G+gQo7oF2We6UIq2mxa USZ09H7cXK9EqarLp6byuBbhcmPn17cSQi7asLqD5QfuZnUXbLnD1npyVfn6oA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1769731387; a=rsa-sha256; cv=none; b=Vm/TOvm1IKjl/4B/EJ5aVmGr5/DO4yy6Eu5M3PGkaRrKehG7tjitWm0K/kWp1osHOYU8f1 +vOICUa28R5EBQRLck+twCAekXxH2HLzDhPSgVbElv0n8rY+6DADX37NesFJFBC/3XmCbF fwB3MK2oG9cpcMD1NlKfT0W7tI6aWgBs6Gyo6s6noFwXVIf8EmmWvS32WBZZvvAB7hOoZA d14LRWOn+tLMW7llNWNJHT93Khf7Q4U0n7beultjXt+uripDq2X6yot8POyvl4SeK/4PMU Nc4qLfhv0PfQ0F7fyQoVppcbby1R8xItmDQO2A/imStIBQoH/Ue+77usBaygQw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1769731387; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=ZrIY3qk+ea/lxc3L88rbPiX+Z0gXQLckml/pKJL2grM=; b=Usw+SaWPciXBiiUITaD11Is2i2Cqbgl05xtmGZoVGoWcEQwli1K06V2K76pH6YiJsz3ZUF 116xF7FJtAh2fMZXGca2fSJvksebT6YP0ao95qFFHAv0sLNs7k+NKJ4QZyrTuWKrOooFdI IlYaKKe2JdHbHw7SqFqA5T45LEEyOVPLa99R5nRRJnqwaTM1opGgKEbuloMqnM0zw7WEMV PDu2H91dS3FW4i5sUUPSSIrjCX3utd9hYKlnDRG4BaqmQjhDzUpP0/EdJjQFnQyplnHhOR VrVD9H0JkE5fhqm/1Ifqf+Fc9vcOf5H2g3X4fk7yXAF7q3QSPM17k2j8rqH2pw== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4f2GRv06fhz10Lm for ; Fri, 30 Jan 2026 00:03:07 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 9d57 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Fri, 30 Jan 2026 00:03:06 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Cc: Abdelkader Boudih From: Kyle Evans Subject: git: fdcd67be8274 - main - firmware: Fix inverted FIRMWARE_GET_NOWARN logic List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kevans X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: fdcd67be8274d237ae2c87d6475d9d34b440b8d8 Auto-Submitted: auto-generated Date: Fri, 30 Jan 2026 00:03:06 +0000 Message-Id: <697bf53a.9d57.6d4deeb4@gitrepo.freebsd.org> The branch main has been updated by kevans: URL: https://cgit.FreeBSD.org/src/commit/?id=fdcd67be8274d237ae2c87d6475d9d34b440b8d8 commit fdcd67be8274d237ae2c87d6475d9d34b440b8d8 Author: Abdelkader Boudih AuthorDate: 2026-01-30 00:02:47 +0000 Commit: Kyle Evans CommitDate: 2026-01-30 00:02:47 +0000 firmware: Fix inverted FIRMWARE_GET_NOWARN logic The try_binary_file() function has inverted logic for the FIRMWARE_GET_NOWARN flag. When the flag is set (meaning "don't warn"), the code sets warn=true and makes noise anyway. Invert the assignment to warn to correctly suppress warnings when FIRMWARE_GET_NOWARN is set. Reviewed by: kevans Differential Revision: https://reviews.freebsd.org/D54955 --- sys/kern/subr_firmware.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sys/kern/subr_firmware.c b/sys/kern/subr_firmware.c index d616339f2c07..88b2e71ba8df 100644 --- a/sys/kern/subr_firmware.c +++ b/sys/kern/subr_firmware.c @@ -281,7 +281,7 @@ try_binary_file(const char *imagename, uint32_t flags) int oflags; size_t resid; int error; - bool warn = flags & FIRMWARE_GET_NOWARN; + bool warn = (flags & FIRMWARE_GET_NOWARN) == 0; /* * XXX TODO: Loop over some path instead of a single element path.