From owner-svn-src-all@freebsd.org Wed Jun 27 23:23:35 2018 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id E50DE101B045; Wed, 27 Jun 2018 23:23:34 +0000 (UTC) (envelope-from philip@trouble.is) Received: from weatherwax.trouble.is (weatherwax.trouble.is [IPv6:2a00:dd80:3c::62e]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "weatherwax.trouble.is", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 7D441787D7; Wed, 27 Jun 2018 23:23:34 +0000 (UTC) (envelope-from philip@trouble.is) Received: from rincewind.trouble.is (rincewind.trouble.is [88.198.44.60]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "rincewind.trouble.is", Issuer "Let's Encrypt Authority X3" (verified OK)) by weatherwax.trouble.is (Postfix) with ESMTPS id 41GJr52QQzz3C1F; Wed, 27 Jun 2018 23:23:33 +0000 (UTC) Received: by rincewind.trouble.is (Postfix, from userid 1001) id 41GJr5001Yz302; Wed, 27 Jun 2018 23:23:32 +0000 (UTC) Date: Thu, 28 Jun 2018 01:23:32 +0200 From: Philip Paeps To: Xin LI Cc: Eitan Adler , "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Subject: Re: svn commit: r335612 - head/sbin/dhclient Message-ID: <20180627232332.GB97785@rincewind.trouble.is> Mail-Followup-To: Xin LI , Eitan Adler , "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" References: <201806250129.w5P1Ts5H017125@repo.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: X-PGP-Fingerprint: 2CD1 92C2 6EE7 B7D1 F552 6619 31AE B9B5 FDBB CB0E X-Date: Today is Prickle-Prickle, the 33rd day of Confusion in the YOLD 3184 X-Phase-of-Moon: The Moon is Full X-Clacks-Overhead: GNU Terry Pratchett Organization: Happily Disorganized User-Agent: Mutt/1.10.0 (2018-05-17) X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 27 Jun 2018 23:23:35 -0000 On 2018-06-25 11:40:48 (-0700), Xin LI wrote: >On Sun, Jun 24, 2018 at 6:30 PM Eitan Adler wrote: >> Author: eadler >> Date: Mon Jun 25 01:29:54 2018 >> New Revision: 335612 >> URL: https://svnweb.freebsd.org/changeset/base/335612 >> >> Log: >> dhclient: recorrect __progname to getprogname() >> >> A more correct way to modernize code that uses __progname is to just >> replace each occurance of it with a call to getprogname(3) > >We should probably take a look at dhcpcd or ISC dhclient and teach >whatever we have chosen sandbox, etc. The current FreeBSD dhclient is >based on an ancient ISC dhclient fork with enhancements from OpenBSD >(but not being kept up-to-date with OpenBSD) and do not support IPv6, >etc. The IPv6 support in ISC dhclient is basically having dhclient and dhclient6, which is a real pain to configure. NetBSD's dhcpcd is probably the best DHCP client these days in terms of completeness. Philip -- Philip Paeps Senior Reality Engineer Ministry of Information