From owner-svn-ports-head@FreeBSD.ORG  Mon Feb 10 09:47:28 2014
Return-Path: <owner-svn-ports-head@FreeBSD.ORG>
Delivered-To: svn-ports-head@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 7CB828AC;
 Mon, 10 Feb 2014 09:47:28 +0000 (UTC)
Received: from theravensnest.org (theraven.freebsd.your.org [216.14.102.27])
 (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by mx1.freebsd.org (Postfix) with ESMTPS id 41B74186C;
 Mon, 10 Feb 2014 09:47:27 +0000 (UTC)
Received: from [192.168.0.7] (cpc28-cmbg15-2-0-cust64.5-4.cable.virginm.net
 [86.27.189.65]) (authenticated bits=0)
 by theravensnest.org (8.14.7/8.14.5) with ESMTP id s1A9lM5Z000410
 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NO);
 Mon, 10 Feb 2014 09:47:24 GMT (envelope-from theraven@FreeBSD.org)
Content-Type: text/plain; charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 7.0 \(1822\))
Subject: Re: svn commit: r343559 - head/net-p2p/litecoin
From: David Chisnall <theraven@FreeBSD.org>
In-Reply-To: <20140210075232.GU80056@ithaqua.etoilebsd.net>
Date: Mon, 10 Feb 2014 09:47:17 +0000
Content-Transfer-Encoding: quoted-printable
Message-Id: <E8F403F4-EA83-4F71-82E6-9BA27D8D217C@FreeBSD.org>
References: <201402092329.s19NTHiq089517@svn.freebsd.org>
 <20140210011718.GA79272@mouf.net>
 <20140210075232.GU80056@ithaqua.etoilebsd.net>
To: Baptiste Daroussin <bapt@FreeBSD.org>
X-Mailer: Apple Mail (2.1822)
Cc: svn-ports-head@FreeBSD.org, Steve Wills <swills@FreeBSD.org>,
 svn-ports-all@FreeBSD.org, John Marino <marino@FreeBSD.org>,
 ports-committers@FreeBSD.org
X-BeenThere: svn-ports-head@freebsd.org
X-Mailman-Version: 2.1.17
Precedence: list
List-Id: SVN commit messages for the ports tree for head
 <svn-ports-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-head/>
List-Post: <mailto:svn-ports-head@freebsd.org>
List-Help: <mailto:svn-ports-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 10 Feb 2014 09:47:28 -0000

On 10 Feb 2014, at 07:52, Baptiste Daroussin <bapt@FreeBSD.org> wrote:

> I do not think that requires an approval, as for FreeBSD this change =
is no-op,
> It is also no intrusive and just "fixes" building of that port for =
Dragonfly.

Relying on OPSYS and OSVERSION is pretty horrible and doesn't scale.  =
Already we have problems with convoluted OSVERSION expressions that are =
hard to understand and really mean 'fix for PR12345 has been merged to =
the relevant branch'.  It would be far better to centralise these into a =
single file for each platform, listing features / bugfixes / needed =
work-arounds and start removing explicit OSVERSION checks from any other =
Makefiles.  If supporting Dragonfly is one of our objectives, then I'd =
strongly encourage the people who are working on it to engage in this =
kind of cleanup, rather than piling more hacks into the tree.

David