From owner-freebsd-ports-bugs@FreeBSD.ORG  Thu Sep 18 10:30:01 2008
Return-Path: <owner-freebsd-ports-bugs@FreeBSD.ORG>
Delivered-To: freebsd-ports-bugs@hub.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 852CA1065673
	for <freebsd-ports-bugs@hub.freebsd.org>;
	Thu, 18 Sep 2008 10:30:01 +0000 (UTC)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
	[IPv6:2001:4f8:fff6::28])
	by mx1.freebsd.org (Postfix) with ESMTP id 615098FC24
	for <freebsd-ports-bugs@hub.freebsd.org>;
	Thu, 18 Sep 2008 10:30:01 +0000 (UTC)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1])
	by freefall.freebsd.org (8.14.2/8.14.2) with ESMTP id m8IAU1om017178
	for <freebsd-ports-bugs@freefall.freebsd.org>;
	Thu, 18 Sep 2008 10:30:01 GMT
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.14.2/8.14.1/Submit) id m8IAU1l4017177;
	Thu, 18 Sep 2008 10:30:01 GMT (envelope-from gnats)
Resent-Date: Thu, 18 Sep 2008 10:30:01 GMT
Resent-Message-Id: <200809181030.m8IAU1l4017177@freefall.freebsd.org>
Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer)
Resent-To: freebsd-ports-bugs@FreeBSD.org
Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org,
	Sergey Skvortsov <skv@protey.ru>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 36CC21065675
	for <FreeBSD-gnats-submit@freebsd.org>;
	Thu, 18 Sep 2008 10:28:08 +0000 (UTC) (envelope-from skv@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
	[IPv6:2001:4f8:fff6::28])
	by mx1.freebsd.org (Postfix) with ESMTP id 25B9B8FC19
	for <FreeBSD-gnats-submit@freebsd.org>;
	Thu, 18 Sep 2008 10:28:08 +0000 (UTC) (envelope-from skv@FreeBSD.org)
Received: from freefall.freebsd.org (skv@localhost [127.0.0.1])
	by freefall.freebsd.org (8.14.2/8.14.2) with ESMTP id m8IAS8rK017145
	for <FreeBSD-gnats-submit@freebsd.org>; Thu, 18 Sep 2008 10:28:08 GMT
	(envelope-from skv@freefall.freebsd.org)
Received: (from skv@localhost)
	by freefall.freebsd.org (8.14.2/8.14.1/Submit) id m8IAS8eX017144;
	Thu, 18 Sep 2008 10:28:08 GMT (envelope-from skv)
Message-Id: <200809181028.m8IAS8eX017144@freefall.freebsd.org>
Date: Thu, 18 Sep 2008 10:28:08 GMT
From: Sergey Skvortsov <godegisel@FreeBSD.org>
To: FreeBSD-gnats-submit@FreeBSD.org
X-Send-Pr-Version: 3.113
Cc: 
Subject: ports/127467: bsd.ports.mk: fix checking DISTDIR for writeability
X-BeenThere: freebsd-ports-bugs@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: Sergey Skvortsov <skv@protey.ru>
List-Id: Ports bug reports <freebsd-ports-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs>, 
	<mailto:freebsd-ports-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports-bugs>
List-Post: <mailto:freebsd-ports-bugs@freebsd.org>
List-Help: <mailto:freebsd-ports-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs>, 
	<mailto:freebsd-ports-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 18 Sep 2008 10:30:01 -0000


>Number:         127467
>Category:       ports
>Synopsis:       bsd.ports.mk: fix checking DISTDIR for writeability
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Thu Sep 18 10:30:01 UTC 2008
>Closed-Date:
>Last-Modified:
>Originator:     Sergey Skvortsov
>Release:        FreeBSD 7.1-PRERELEASE i386
>Organization:
>Environment:


>Description:

>How-To-Repeat:

# run as unprivileged user in 'wheel' group

sudo chmod g+w /usr/ports/distfiles/vim

cd /usr/ports/editors/vim-lite

make fetch

[skip]

=> vim-7.2.tar.bz2 doesn't seem to exist in /usr/ports/distfiles/vim.
=> /usr/ports/distfiles is not writable by you; cannot fetch.

>Fix:

Check real dir, not the parent.

Index: bsd.port.mk
===================================================================
RCS file: /home/pcvs/ports/Mk/bsd.port.mk,v
retrieving revision 1.604
diff -u -r1.604 bsd.port.mk
--- bsd.port.mk	5 Sep 2008 19:41:43 -0000	1.604
+++ bsd.port.mk	18 Sep 2008 09:26:54 -0000
@@ -3413,8 +3413,8 @@
 				fi; \
 			fi; \
 			${ECHO_MSG} "=> $$file doesn't seem to exist in ${_DISTDIR}."; \
-			if [ ! -w ${DISTDIR} ]; then \
-			   ${ECHO_MSG} "=> ${DISTDIR} is not writable by you; cannot fetch."; \
+			if [ ! -w ${_DISTDIR} ]; then \
+			   ${ECHO_MSG} "=> ${_DISTDIR} is not writable by you; cannot fetch."; \
 			   exit 1; \
 			fi; \
 			if [ ! -z "$$select" ] ; then \
>Release-Note:
>Audit-Trail:
>Unformatted: