From owner-freebsd-mobile@FreeBSD.ORG  Thu Dec 11 17:52:16 2003
Return-Path: <owner-freebsd-mobile@FreeBSD.ORG>
Delivered-To: freebsd-mobile@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id D2BCB16A4CE; Thu, 11 Dec 2003 17:52:16 -0800 (PST)
Received: from harmony.village.org (rover.bsdimp.com [204.144.255.66])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 7FDB343D33; Thu, 11 Dec 2003 17:52:15 -0800 (PST)
	(envelope-from imp@bsdimp.com)
Received: from localhost (warner@rover2.village.org [10.0.0.1])
	by harmony.village.org (8.12.10/8.12.9) with ESMTP id hBC1q95h011572;
	Thu, 11 Dec 2003 18:52:09 -0700 (MST)
	(envelope-from imp@bsdimp.com)
Date: Thu, 11 Dec 2003 18:49:21 -0700 (MST)
Message-Id: <20031211.184921.67799178.imp@bsdimp.com>
To: grog@FreeBSD.org
From: "M. Warner Losh" <imp@bsdimp.com>
In-Reply-To: <20031212012532.GB81968@wantadilla.lemis.com>
References: <20031212010434.GY81968@wantadilla.lemis.com>
	<20031211.181241.58839617.imp@bsdimp.com>
	<20031212012532.GB81968@wantadilla.lemis.com>
X-Mailer: Mew version 2.1 on Emacs 21.3 / Mule 5.0 (SAKAKI)
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
cc: mobile@FreeBSD.org
Subject: Re: Still problems with Lucent wi0
X-BeenThere: freebsd-mobile@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Mobile computing with FreeBSD <freebsd-mobile.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-mobile>,
	<mailto:freebsd-mobile-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-mobile>
List-Post: <mailto:freebsd-mobile@freebsd.org>
List-Help: <mailto:freebsd-mobile-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-mobile>,
	<mailto:freebsd-mobile-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 12 Dec 2003 01:52:17 -0000

In message: <20031212012532.GB81968@wantadilla.lemis.com>
            "Greg 'groggy' Lehey" <grog@FreeBSD.org> writes:
: On Thursday, 11 December 2003 at 18:12:41 -0700, M. Warner Losh wrote:
: > Are you runnign current?
: 
: For some definition of "current", yes.  30 November.

That's not current enough.  I committed the fixes for that the next
day:

imp         2003/12/01 20:59:59 PST

  FreeBSD src repository

  Modified files:
    sys/dev/wi           if_wi.c 
  Log:
  Fix Lucent cards.
  o Back out workaround for not resetting lucent cards more than once.  With
    these fixes, it appaers they are no longer necessary.
  o Set wi_gone when the card goes awol: typically when we get 0xffff back from
    the card.  Also, don't interact with a card that's gone, so we fail in
    seconds rather than minutes.  Also reduce amount of time we wait to .5s
    in wi_cmd.
  o clear wi_gone on ifconfig down to give some cards a chance after they wedge
    (this appears to unwedge one of my prism cards with old firmware).  ifconfig
    up will fail quickly enough if the card really is out to lunch.
  o Add delay in wi_init of 100ms.
  o wi_stop(ifp, 0->1) changes so that we clear sc_enabled so that we
    exit out of the interrupt routine by just acking the interrupt
  
  Submitted by: iedowse
  Approved by: re@ (scottl)
  
  # after the freeze I'll fix some of the minor style issues that reviewers
  # of this patch have told me about.
  
  Revision  Changes    Path
  1.158     +25 -10    src/sys/dev/wi/if_wi.c

: > The 'bad alloc' stuff was fixed a little while ago.
: 
: Yes, I thought so too.  I haven't seen any more commits of that nature
: since then.  Should I go to today's current?

Yes.  It should be much better.

Warner