From owner-freebsd-ports@FreeBSD.ORG Sun Aug 31 07:51:04 2014 Return-Path: Delivered-To: freebsd-ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 67C4CE1A for ; Sun, 31 Aug 2014 07:51:04 +0000 (UTC) Received: from home.opsec.eu (home.opsec.eu [IPv6:2001:14f8:200::1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 1F7B31542 for ; Sun, 31 Aug 2014 07:51:04 +0000 (UTC) Received: from pi by home.opsec.eu with local (Exim 4.82 (FreeBSD)) (envelope-from ) id 1XNzud-000CwT-7v; Sun, 31 Aug 2014 09:50:59 +0200 Date: Sun, 31 Aug 2014 09:50:59 +0200 From: Kurt Jaeger To: Ted Faber Subject: Re: How to submit a port update? Message-ID: <20140831075059.GW9400@home.opsec.eu> References: <5401F646.6030304@lunabase.org> <20140830175001.GS9400@home.opsec.eu> <54023CF9.1040002@lunabase.org> <20140830212321.GV9400@home.opsec.eu> <540250CF.5010803@lunabase.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <540250CF.5010803@lunabase.org> Cc: freebsd-ports@freebsd.org X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 31 Aug 2014 07:51:04 -0000 Hi! > The update is mostly some small changes to the code to eliminate clang++ > and recent g++ warnings along with Eric's typo, which has been > languishing for a while. I know it's a small thing, but seeing those > warnings when I compile the port makes me sad. Obviously you guys can > reject if you don't feel it's worth it. Well, it's always nice to check process and procedures while it's not time-critical 8-} And you are right, the porters handbook still mentions send-pr. There is one thing which is very nice to have for an incoming PR: poudriere test logs that prove that the updated port builds cleanly. If you never used poudriere, have a look at this short starter guide: https://fossil.etoilebsd.net/poudriere/doc/trunk/doc/using_testport.wiki > That changes the port diff, of course. The new one is attached, or I > can update bugzilla. Always update bugzilla (says the guy who preferres mail...) > Sorry to bug you if it's too trivial a change. No, it's fine. I guess I would only release new versions if runtime bugs or runtime functionality changes. You also updated the autotools environment, maybe that fixes other stuff as well. You re-rolled the distfile without a version change, this is not purrrfect, but well, what else is 8-) -- pi@opsec.eu +49 171 3101372 6 years to go !