From owner-svn-src-all@FreeBSD.ORG  Thu Nov 19 01:11:16 2009
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 9EA6F1065676;
	Thu, 19 Nov 2009 01:11:16 +0000 (UTC)
	(envelope-from davidxu@freebsd.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
	[IPv6:2001:4f8:fff6::28])
	by mx1.freebsd.org (Postfix) with ESMTP id 8BCF18FC20;
	Thu, 19 Nov 2009 01:11:16 +0000 (UTC)
Received: from apple.my.domain (localhost [127.0.0.1])
	by freefall.freebsd.org (8.14.3/8.14.3) with ESMTP id nAJ1BE7x006003;
	Thu, 19 Nov 2009 01:11:15 GMT (envelope-from davidxu@freebsd.org)
Message-ID: <4B049B32.6090801@freebsd.org>
Date: Thu, 19 Nov 2009 09:11:14 +0800
From: David Xu <davidxu@freebsd.org>
User-Agent: Thunderbird 2.0.0.9 (X11/20080612)
MIME-Version: 1.0
To: "M. Warner Losh" <imp@bsdimp.com>
References: <200911180509.nAI593kQ058970@svn.freebsd.org>
	<20091118.072514.673374189.imp@bsdimp.com>
In-Reply-To: <20091118.072514.673374189.imp@bsdimp.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
	src-committers@freebsd.org
Subject: Re: svn commit: r199469 - head/lib/librt
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
	user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 19 Nov 2009 01:11:16 -0000

M. Warner Losh wrote:
> In message: <200911180509.nAI593kQ058970@svn.freebsd.org>
>             David Xu <davidxu@freebsd.org> writes:
> : Author: davidxu
> : Date: Wed Nov 18 05:09:03 2009
> : New Revision: 199469
> : URL: http://svn.freebsd.org/changeset/base/199469
> : 
> : Log:
> :   link libpthread because the librt really needs it to fully function.
> 
> If you are now requiring libpthread, why are you using the _pthread_*
> functions everywhere else?
> 
> Warner

now the pthread_cleanup_push is a macro, but originally it is a
function.

I don't know if we need an underline version of pthread_cleanup_push,
it is trivial if one wants to add it.