Date: Sun, 21 Feb 2010 10:38:07 GMT From: Dominic Fandrey <kamikaze@bsdforen.de> To: freebsd-gnats-submit@FreeBSD.org Subject: ports/144164: make package-noinstall does not include rc.d scripts Message-ID: <201002211038.o1LAc7Ff063600@www.freebsd.org> Resent-Message-ID: <201002211040.o1LAe2wG034029@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 144164 >Category: ports >Synopsis: make package-noinstall does not include rc.d scripts >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Sun Feb 21 10:40:02 UTC 2010 >Closed-Date: >Last-Modified: >Originator: Dominic Fandrey >Release: RELENG_8 >Organization: private >Environment: FreeBSD mobileKamikaze.norad 8.0-STABLE FreeBSD 8.0-STABLE #0: Tue Feb 16 16:15:46 CET 2010 root@mobileKamikaze.norad:/usr/obj/HP6510b-8/amd64/usr/src/sys/HP6510b-8 amd64 >Description: The package-noinstall target does not include rc.d scripts, because it does not ensure that RC scripts have been added to the TMPPLIST file. See also the mailing list thread in ports@: http://docs.freebsd.org/cgi/mid.cgi?c1a0d1561002200755q4ab28515ic550fca1789e1cd8 >How-To-Repeat: Run "make package-noinstall" for a port that installs an rc.d script. Make sure that the work directory is clean before you do so. tar -tf /usr/ports/packages/All/pkgname.tbz will show you that the rc.d script is missing. >Fix: wxs has a patch that adds the check: http://people.freebsd.org/~wxs/package-noinstall-rc-script.diff I instead propose to remove this functionality from bsd.port.mk and instead rely on "pkg_create -b". Patch attached with submission follows: --- bsd.port.mk.orig 2010-02-21 10:44:50.000000000 +0100 +++ bsd.port.mk 2010-02-21 10:54:53.000000000 +0100 @@ -3869,20 +3869,7 @@ fi; \ fi @__softMAKEFLAGS='${__softMAKEFLAGS:S/'/'\''/g}'; \ - _LATE_PKG_ARGS=""; \ - if [ -f ${PKGINSTALL} ]; then \ - _LATE_PKG_ARGS="$${_LATE_PKG_ARGS} -i ${PKGINSTALL}"; \ - fi; \ - if [ -f ${PKGDEINSTALL} ]; then \ - _LATE_PKG_ARGS="$${_LATE_PKG_ARGS} -k ${PKGDEINSTALL}"; \ - fi; \ - if [ -f ${PKGREQ} ]; then \ - _LATE_PKG_ARGS="$${_LATE_PKG_ARGS} -r ${PKGREQ}"; \ - fi; \ - if [ -f ${PKGMESSAGE} ]; then \ - _LATE_PKG_ARGS="$${_LATE_PKG_ARGS} -D ${PKGMESSAGE}"; \ - fi; \ - if ${PKG_CMD} ${PKG_ARGS} ${PKGFILE}; then \ + if ${PKG_CMD} -b ${PKGNAME} ${PKGFILE}; then \ if [ -d ${PACKAGES} ]; then \ cd ${.CURDIR} && eval ${MAKE} $${__softMAKEFLAGS} package-links; \ fi; \ >Release-Note: >Audit-Trail: >Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201002211038.o1LAc7Ff063600>