From owner-svn-src-head@freebsd.org Thu Nov 8 16:56:12 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 8FC001130710; Thu, 8 Nov 2018 16:56:12 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: from mail-io1-xd44.google.com (mail-io1-xd44.google.com [IPv6:2607:f8b0:4864:20::d44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id E454087387; Thu, 8 Nov 2018 16:56:11 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: by mail-io1-xd44.google.com with SMTP id 79-v6so15133024iou.2; Thu, 08 Nov 2018 08:56:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=k1yRlqYDSuy0NatX4Vxzw9ob0TUgkwcKokOwzO7H9tg=; b=CTyjz034/bOxZC+n9H5k4mjO4adHmr5p/8Xuf1XUsSy7oP/WEcfjuxeAtOskN9+i4z MsVE6nWAykQUUVUQR7+xq2FuXzzAnt4N7wXVBJYt2O6yupeXjtoO/XZTJ+a6EhYxm/yv zu9NhoCI8a2Bz5d6CXaEpUyh4clJl1Czzh15v7Tp4yj2UXrJUItoIJwCuX4zvqCpR9yZ PGPF709+MecL3w4snGKIYxfFg6rg8N823beoDUUZhp9CsVgM212d1YaG+paWzEHq+FCH DmjBYB4YPJOi3BjCmc2PmXefVQzZ7rQY5Qgc2TTRjnqztc66Gkiu7NsRmc/WaWX3cWE1 3eGw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to:user-agent; bh=k1yRlqYDSuy0NatX4Vxzw9ob0TUgkwcKokOwzO7H9tg=; b=od6m+jfl4Jtk3NVrtO/KLfwsgcrg6wjS4VZJE6zjXl0KcSuGIJFI+biPT56Cmdcwph XPomYITxH8JHVQPG5GJ7sxEwm4AairmTuGhPgxj4O5ZSHUSYldZ4TfmQYMBYsjqqWTWb t8USFpGf4OchLHvr9ElLuW4In8Vu1KpKgVTsPUxtVocDmOm26cDsFkFMevLS4u1x1IX4 h3v4t9RShs0mlBFi8Hw/eIYMySDX8+Lo+0azv+3QqTHCrVrQW2BQ0cv7Hq/uSaO4XtpS Xj4KISJYQKS6I+q4HYGi0sI8WuD69RjIKrb8w424VVhj82cJ7Ho/I2pVvPRwRTTg9khk +gqw== X-Gm-Message-State: AGRZ1gK7LjuVFNosqlZOLF1jg+PkMu/GNOMsFydntNQVKTCr7kYXYaLy amt/n+UcXWh8IlBhGSBMuy/NO+XB X-Google-Smtp-Source: AJdET5cxNE2ZYi6NEeEfWg/y8og95sDKG44H4+HTIw5GR2LqfYV8D4alx7txQJDKY3XVC0/kzDdDDA== X-Received: by 2002:a6b:c982:: with SMTP id z124-v6mr4267386iof.130.1541696171225; Thu, 08 Nov 2018 08:56:11 -0800 (PST) Received: from raichu (toroon0560w-lp130-08-67-71-176-199.dsl.bell.ca. [67.71.176.199]) by smtp.gmail.com with ESMTPSA id h24-v6sm1430536iog.81.2018.11.08.08.56.10 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 08 Nov 2018 08:56:10 -0800 (PST) Sender: Mark Johnston Date: Thu, 8 Nov 2018 11:56:08 -0500 From: Mark Johnston To: Hans Petter Selasky Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r340246 - head/usr.sbin/newsyslog Message-ID: <20181108165608.GE24751@raichu> References: <201811081243.wA8ChEsP009030@repo.freebsd.org> <20181108161429.GA24751@raichu> <19afa685-8109-566c-6a8a-91b712e80fe9@selasky.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <19afa685-8109-566c-6a8a-91b712e80fe9@selasky.org> User-Agent: Mutt/1.10.1 (2018-07-13) X-Rspamd-Queue-Id: E454087387 X-Spamd-Result: default: False [-3.32 / 200.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; R_DKIM_ALLOW(-0.20)[gmail.com]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4000::/36]; NEURAL_HAM_LONG(-1.00)[-0.999,0]; MIME_GOOD(-0.10)[text/plain]; RCVD_TLS_LAST(0.00)[]; DMARC_NA(0.00)[freebsd.org]; TO_DN_SOME(0.00)[]; RCVD_COUNT_THREE(0.00)[3]; TO_MATCH_ENVRCPT_SOME(0.00)[]; DKIM_TRACE(0.00)[gmail.com:+]; MX_GOOD(-0.01)[cached: alt3.gmail-smtp-in.l.google.com]; RCVD_IN_DNSWL_NONE(0.00)[4.4.d.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.b.8.f.7.0.6.2.list.dnswl.org : 127.0.5.0]; NEURAL_HAM_SHORT(-0.94)[-0.943,0]; IP_SCORE(-0.66)[ipnet: 2607:f8b0::/32(-1.66), asn: 15169(-1.57), country: US(-0.09)]; FORGED_SENDER(0.30)[markj@freebsd.org,markjdb@gmail.com]; MID_RHS_NOT_FQDN(0.50)[]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; FROM_NEQ_ENVFROM(0.00)[markj@freebsd.org,markjdb@gmail.com] X-Rspamd-Server: mx1.freebsd.org X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 08 Nov 2018 16:56:12 -0000 On Thu, Nov 08, 2018 at 05:24:49PM +0100, Hans Petter Selasky wrote: > On 11/8/18 5:14 PM, Mark Johnston wrote: > > On Thu, Nov 08, 2018 at 12:43:14PM +0000, Hans Petter Selasky wrote: > >> Author: hselasky > >> Date: Thu Nov 8 12:43:13 2018 > >> New Revision: 340246 > >> URL: https://svnweb.freebsd.org/changeset/base/340246 > >> > >> Log: > >> Add /var/log/opensm.log to list of rotating log files. > >> > >> MFC after: 3 days > >> Sponsored by: Mellanox Technologies > >> > >> Modified: > >> head/usr.sbin/newsyslog/newsyslog.conf > > > > There is already an usr.sbin/newsyslog/newsyslog.d/opensm.conf. > > > Thank you. Do you have any objections adding a size limit for > opensm.conf, and also to use bzip2? Nope. I don't interact with opensm anymore though. FWIW, opensm's logging can be quite verbose and I very often found myself wanting to go back further than the log retention limit (which was fairly small due to space constraints on OneFS). I think switching to bzip2 is a good idea, and the size limit you added looks reasonable. > > Index: usr.sbin/newsyslog/newsyslog.conf.d/opensm.conf > > =================================================================== > > --- usr.sbin/newsyslog/newsyslog.conf.d/opensm.conf (revision 339922) > > +++ usr.sbin/newsyslog/newsyslog.conf.d/opensm.conf (working copy) > > @@ -1,3 +1,3 @@ > > # $FreeBSD$ > > > > -/var/log/opensm.log 600 7 * * Z /var/run/opensm.pid 30 > > +/var/log/opensm.log 600 7 1000 * J /var/run/opensm.pid 30 > > --HPS > > >> > >> Modified: head/usr.sbin/newsyslog/newsyslog.conf > >> ============================================================================== > >> --- head/usr.sbin/newsyslog/newsyslog.conf Thu Nov 8 09:45:13 2018 (r340245) > >> +++ head/usr.sbin/newsyslog/newsyslog.conf Thu Nov 8 12:43:13 2018 (r340246) > >> @@ -26,6 +26,7 @@ > >> /var/log/maillog 640 7 * @T00 JC > >> /var/log/messages 644 5 1000 @0101T JC > >> /var/log/monthly.log 640 12 * $M1D0 JN > >> +/var/log/opensm.log 644 3 1000 * J > >> /var/log/devd.log 644 3 1000 * JC > >> /var/log/security 600 10 1000 * JC > >> /var/log/utx.log 644 3 * @01T05 B > >> > > > > >