From owner-svn-doc-head@freebsd.org  Tue Jan  3 21:56:18 2017
Return-Path: <owner-svn-doc-head@freebsd.org>
Delivered-To: svn-doc-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 7C659C9D1B0;
 Tue,  3 Jan 2017 21:56:18 +0000 (UTC)
 (envelope-from wblock@wonkity.com)
Received: from wonkity.com (wonkity.com [67.158.26.137])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client CN "wonkity.com", Issuer "wonkity.com" (not verified))
 by mx1.freebsd.org (Postfix) with ESMTPS id 444FA1DD9;
 Tue,  3 Jan 2017 21:56:17 +0000 (UTC)
 (envelope-from wblock@wonkity.com)
Received: from wonkity.com (localhost [127.0.0.1])
 by wonkity.com (8.15.2/8.15.2) with ESMTPS id v03LuGZh063374
 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO);
 Tue, 3 Jan 2017 14:56:16 -0700 (MST)
 (envelope-from wblock@wonkity.com)
Received: from localhost (wblock@localhost)
 by wonkity.com (8.15.2/8.15.2/Submit) with ESMTP id v03LuFwK063371;
 Tue, 3 Jan 2017 14:56:16 -0700 (MST)
 (envelope-from wblock@wonkity.com)
Date: Tue, 3 Jan 2017 14:56:15 -0700 (MST)
From: Warren Block <wblock@wonkity.com>
To: Maxim Konovalov <maxim.konovalov@gmail.com>
cc: Warren Block <wblock@FreeBSD.org>, doc-committers@freebsd.org,
 svn-doc-all@freebsd.org, svn-doc-head@freebsd.org
Subject: Re: svn commit: r49600 - head/en_US.ISO8859-1/books/handbook/firewalls
In-Reply-To: <alpine.BSF.2.20.1701031927070.83306@mp2.macomnet.net>
Message-ID: <alpine.BSF.2.20.1701031454590.52533@wonkity.com>
References: <201610281531.u9SFVL7u096914@repo.freebsd.org>
 <alpine.BSF.2.20.1701021904430.83306@mp2.macomnet.net>
 <alpine.BSF.2.20.1701022145290.98030@wonkity.com>
 <alpine.BSF.2.20.1701031927070.83306@mp2.macomnet.net>
User-Agent: Alpine 2.20 (BSF 67 2015-01-07)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII; format=flowed
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.6.1
 (wonkity.com [127.0.0.1]); Tue, 03 Jan 2017 14:56:16 -0700 (MST)
X-BeenThere: svn-doc-head@freebsd.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: SVN commit messages for the doc tree for head
 <svn-doc-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-doc-head>,
 <mailto:svn-doc-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-doc-head/>
List-Post: <mailto:svn-doc-head@freebsd.org>
List-Help: <mailto:svn-doc-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-doc-head>,
 <mailto:svn-doc-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 03 Jan 2017 21:56:18 -0000

On Tue, 3 Jan 2017, Maxim Konovalov wrote:

>>> Hi Warren,
>>>
>>> On Fri, 28 Oct 2016, 15:31-0000, Warren Block wrote:
>>>
>>> [...]
>>>>  # Allow outbound NTP
>>>> -&dollar;cmd 00260 allow tcp from any to any 37 out via &dollar;pif setup
>>>> keep-state
>>>> +&dollar;cmd 00260 allow udp from any to any 123 out via &dollar;pif setup
>>>> keep-state
>>>>
>>>>  # Allow outbound SSH
>>>>  &dollar;cmd 00280 allow tcp from any to any 22 out via &dollar;pif setup
>>>> keep-state
>>>>
>>> Are you sure about this change?  NTP is UDP based protocol.  In the
>>> same time "setup" is TCP only feature (why ipfw(8) allows it to use in
>>> conjunction with the UDP proto is a different story)
>>>
>>> I think the comment is what should be fixed here.
>>
>> https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=213365 suggested merely
>> changing this to UDP 123.  I don't use IPFW, so can't verify the actual usage.
>> Help would be appreciated.
>>
> I'd remove the "setup" keyword from the command.  Let me know if I can
> go ahead with this change.

It's okay with me.  Er, "Approved".  It would be really nice if you 
could test and verify it, but not required.

Thanks!