From owner-svn-src-head@freebsd.org Fri Mar 15 14:12:04 2019 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 4A0DD154A145 for ; Fri, 15 Mar 2019 14:12:04 +0000 (UTC) (envelope-from ian@freebsd.org) Received: from outbound2m.ore.mailhop.org (outbound2m.ore.mailhop.org [54.149.155.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id B11E769E67 for ; Fri, 15 Mar 2019 14:12:03 +0000 (UTC) (envelope-from ian@freebsd.org) ARC-Seal: i=1; a=rsa-sha256; t=1552658152; cv=none; d=outbound.mailhop.org; s=arc-outbound20181012; b=VM2Hrpb7IjQvcNl2cWMv7R/Bfz6aMFfJBa5mIqKgtiltT2En8etrFO4xv0lAY9KO9aVTGpyq7BMFs KcJMBhdVRAqXxt2CReXwxjKawxh5AkRSWLAgN5rWWmRFY9Vw6VZVoK7iMlfZyiwnjXyZ/5Xcjj7aqH 2R3iUiGB9JEXZVtDZR/FuXxWOya1ISHrRL+JSsD0JyBjBkbuDA5nGiIPYFhCJ9ybDIpLx6cBum5o7Z jDPxLbepyk6zxzTm205dS7uw2UEzKFpxH8SsDmaUYNZZxdhrG5mA0BArPLfHbK1hNIR8AZYnPzzt3Q /bh5hVm5XH4svRjvmsZDVAaFCZ55xKA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=outbound.mailhop.org; s=arc-outbound20181012; h=content-transfer-encoding:mime-version:content-type:references:in-reply-to: date:cc:to:from:subject:message-id:dkim-signature:from; bh=8x3q5AW+I/OljRBAtZ8Oq0lAoX8pRw82f0wL37+232Y=; b=T3AnmwGb1kM3NgRhQZcPju++TyFLB4zy3OD7cFROqSLxaBH0j2742Px8pxwlP+pFYhEFLN5kqLMet GsW14Dia4iio3L/bAAan1VjkDB4QIIM7AzHB0xDjr7itCsMxSrGD4fLvByzUwMRC/OTQR9PBmj6HTW YaZTxFcc0QfvfiBfAiiYm5BR0G/UU27+aFLb6YQk1hkYNCOgLWy2fY872t76qZBuUDJT7toLHapSvG cswepn4jizI+hfLMJJqsLRrlqZpUXgdstTAJNuAhkX8KzPfYOsgXoKStCwDf/ObpCgcCmgKswpno8B o4j8Ejb807PoL9ibxLvp2Sl6NGD+d1A== ARC-Authentication-Results: i=1; outbound4.ore.mailhop.org; spf=softfail smtp.mailfrom=freebsd.org smtp.remote-ip=67.177.211.60; dmarc=none header.from=freebsd.org; arc=none header.oldest-pass=0; DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outbound.mailhop.org; s=dkim-high; h=content-transfer-encoding:mime-version:content-type:references:in-reply-to: date:cc:to:from:subject:message-id:from; bh=8x3q5AW+I/OljRBAtZ8Oq0lAoX8pRw82f0wL37+232Y=; b=tGzYy+CWqJJpSGsJ2RWvI91pv56JsJZWq8ccUBJ2zAlbpleJrAk1RKA+mkI3TybUXJSpZQtn+7pNu anf5AhQFEQuBiKLp9eqXQxN0UzskJnfhJwXPWgRWpZGT0T0Bg652hQhs9P231zDrCdInAwnU+HMPOy CLTjUNFiTdiJzHfZmISJXw8impVwDt4c5Qs1qpQJDwcqSQktDfnlkjrKSAIaR7nu8PElqCWHXiB5sU 263zpIWqm74lW+IypP5ywAVvVZJLAtlh6/8noK64TWmaq0XA85iuue3DHiujDSn6Dp0XLmO2h5IRKd QtbcjihO4oAAzQWZJoTlg38oZghaRvQ== X-MHO-RoutePath: aGlwcGll X-MHO-User: 0a2dffe1-472a-11e9-befd-af03bedce89f X-Report-Abuse-To: https://support.duocircle.com/support/solutions/articles/5000540958-duocircle-standard-smtp-abuse-information X-Originating-IP: 67.177.211.60 X-Mail-Handler: DuoCircle Outbound SMTP Received: from ilsoft.org (unknown [67.177.211.60]) by outbound4.ore.mailhop.org (Halon) with ESMTPSA id 0a2dffe1-472a-11e9-befd-af03bedce89f; Fri, 15 Mar 2019 13:55:51 +0000 (UTC) Received: from rev (rev [172.22.42.240]) by ilsoft.org (8.15.2/8.15.2) with ESMTP id x2FDtnaS054649; Fri, 15 Mar 2019 07:55:49 -0600 (MDT) (envelope-from ian@freebsd.org) Message-ID: <7e312cdad08139c567cd43207191c97303831e9d.camel@freebsd.org> Subject: Re: svn commit: r345171 - head/usr.sbin/bhyve From: Ian Lepore To: rgrimes@freebsd.org, Chuck Tuffli Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Date: Fri, 15 Mar 2019 07:55:49 -0600 In-Reply-To: <201903150231.x2F2VnR6027995@gndrsh.dnsmgr.net> References: <201903150231.x2F2VnR6027995@gndrsh.dnsmgr.net> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5 FreeBSD GNOME Team Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: B11E769E67 X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.99 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_SHORT(-0.99)[-0.993,0]; REPLY(-4.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0] X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 15 Mar 2019 14:12:04 -0000 On Thu, 2019-03-14 at 19:31 -0700, Rodney W. Grimes wrote: > > Author: chuck > > Date: Fri Mar 15 02:11:28 2019 > > New Revision: 345171 > > URL: https://svnweb.freebsd.org/changeset/base/345171 > > > > Log: > > Fix bhyve PCIe capability emulation > > > > PCIe devices starting with version 1.1 must set the Role-Based > > Error > > Reporting bit. > > > > And while we're in the neighborhood, generalize the code > > assigning the > > device type. > > > > Reviewed by: imp, araujo, rgrimes > > Approved by: imp (mentor) > > MFC after: 1 week > > Differential Revision: https://reviews.freebsd.org/D19580 > > This code requires maintainer approval before a commit, > though this was well reviewed that doesnt exclude it > from the MAINTAINERS entry. > Where exactly does it say that in MAINTAINERS? As another victim of this sort of drive-by lynching after making a trivial bhyve change I pretty seriously object to a vague and meaningless entry in MAINTAINERS being used to pounce on anyone who dares to touch the precious bhyve code. There is no mention of bhyve in MAINTAINERS, for usr.sbin or elsewhere. There is an entry for vmm(4), which to me does not say anything about bhyve, yet somehow everybody is supposed to know what it means and what-all territory it covers? IMO, this sort of hyper-proprietary pouncing on everyone who dares change a single line of code is not productive. It is HIGHLY de- motivating. Large sweeping design changes are one thing, but pouncing on every tiny minor commit is just not helpful. -- Ian > Leave it for now, I am sure jhb or thyco are fine with it, > this is just a heads up FYI for future commits. > > Bhyve code has been and still is under a fairly tight > MAINTAINER status. > > > Modified: > > head/usr.sbin/bhyve/pci_emul.c > > > > Modified: head/usr.sbin/bhyve/pci_emul.c > > =================================================================== > > =========== > > --- head/usr.sbin/bhyve/pci_emul.c Fri Mar 15 02:11:27 2019 (r3 > > 45170) > > +++ head/usr.sbin/bhyve/pci_emul.c Fri Mar 15 02:11:28 2019 (r3 > > 45171) > > @@ -953,7 +953,10 @@ pci_emul_add_pciecap(struct pci_devinst *pi, > > int type) > > bzero(&pciecap, sizeof(pciecap)); > > > > pciecap.capid = PCIY_EXPRESS; > > - pciecap.pcie_capabilities = PCIECAP_VERSION | > > PCIEM_TYPE_ROOT_PORT; > > + pciecap.pcie_capabilities = PCIECAP_VERSION | type; > > + /* Devices starting with version 1.1 must set the RBER bit */ > > + if (PCIECAP_VERSION >= 1) > > + pciecap.dev_capabilities = PCIEM_CAP_ROLE_ERR_RPT; > > pciecap.link_capabilities = 0x411; /* gen1, x1 */ > > pciecap.link_status = 0x11; /* gen1, x1 */ > > > > > > > >