From owner-svn-src-head@freebsd.org Fri Sep 27 00:29:30 2019 Return-Path: Delivered-To: svn-src-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 60150F07DA for ; Fri, 27 Sep 2019 00:29:30 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-qt1-x830.google.com (mail-qt1-x830.google.com [IPv6:2607:f8b0:4864:20::830]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 46fXjj4wTGz49FY for ; Fri, 27 Sep 2019 00:29:29 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-qt1-x830.google.com with SMTP id w14so5137002qto.9 for ; Thu, 26 Sep 2019 17:29:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=OX7Rfh782febAYDmpjI9CCjYKOa1luLZL7QUvaeWaiY=; b=H9js1uncO+PtXu7MKs8QPYy3WD0xSq/EQCY/hHTV0iwNn0Ws3Ev/hNWrggefSvB5Jz qaM/bSQa5fG4c1PK9M5r86gVEztOynnc8X4VfPK/LMF32D2Jzd7BDaFpN6uydFLONVSJ K/H9K9/tNV+TYgzfYMgyxLT5zKciDgQUJRZ1l9PoRdwDHmDw6GbqGmxyUP2cnTBWajR0 bZgrOC0si8YZqgQkfOd+r+yC+SJ8xMM4Z2Sny3OdigsYKqxSO/bmaOQ6WJERn7ubFTBX /bUSXn3siKLEzqkZOPZ1hE1GVvZf/n1lzevQTm5le34TgEwQYH+809bPxgawSFn5aWDa hmqQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=OX7Rfh782febAYDmpjI9CCjYKOa1luLZL7QUvaeWaiY=; b=PZa4IrT5FP3xfqG4UQp+zgoK1UoJKMCWlJqjcHD/fiSuv3skyW3lG3M4wJdPR3IL2s OhARWhJPPguIVhh3TEy+JV/xKZLOU32mqClDkDQCzb/sx2sXbJUc+IuTzvZsCIIRDLOq hoEA5YjmnhKWflawhCfoUMY6LVPYlWG5D7KeVrWRtY6mQjXQTtl7U1KXnM8vnTAKa0kG 5cRliJgOODnUDro4iFOIMAp2ho9LL7JRoUMMrHwJcLySMK5aWITi8VGvf1nWrsDAVIfQ pMGKrkZrRRIk4J7y9qr0wMqTnH7Yv8pIysi4dyTRkbZPjwD6miymCHieLNmIWfT4sIkc v+NA== X-Gm-Message-State: APjAAAWbQ2vHPzcME1A5lcJ1Qpna2Vme5xvJLTYyO/AjaWLQjxkhXAut mTo9VNZCnTrFdOBWG8L0oUw3+7ev1AazIoZ4kzoDyA== X-Google-Smtp-Source: APXvYqwz1yx2xA6V/nNEvkZlbyVOKCJGtBRo2/xgVqP/mEJPLoeN2AdVRUkmSW1eo+romSd4mNB7+E2D6k5GN9bptjo= X-Received: by 2002:ac8:44c9:: with SMTP id b9mr7218637qto.175.1569544167832; Thu, 26 Sep 2019 17:29:27 -0700 (PDT) MIME-Version: 1.0 References: <201909262112.x8QLCl9o061816@repo.freebsd.org> In-Reply-To: From: Warner Losh Date: Thu, 26 Sep 2019 18:29:16 -0600 Message-ID: Subject: Re: svn commit: r352778 - in head/sys: conf sys To: Ryan Stone Cc: Gleb Smirnoff , src-committers , svn-src-all , svn-src-head X-Rspamd-Queue-Id: 46fXjj4wTGz49FY X-Spamd-Bar: --- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=bsdimp-com.20150623.gappssmtp.com header.s=20150623 header.b=H9js1unc; dmarc=none; spf=none (mx1.freebsd.org: domain of wlosh@bsdimp.com has no SPF policy when checking 2607:f8b0:4864:20::830) smtp.mailfrom=wlosh@bsdimp.com X-Spamd-Result: default: False [-3.83 / 15.00]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; R_DKIM_ALLOW(-0.20)[bsdimp-com.20150623.gappssmtp.com:s=20150623]; FROM_HAS_DN(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; PREVIOUSLY_DELIVERED(0.00)[svn-src-head@freebsd.org]; DMARC_NA(0.00)[bsdimp.com]; URI_COUNT_ODD(1.00)[3]; RCPT_COUNT_FIVE(0.00)[5]; TO_MATCH_ENVRCPT_SOME(0.00)[]; TO_DN_ALL(0.00)[]; DKIM_TRACE(0.00)[bsdimp-com.20150623.gappssmtp.com:+]; RCVD_IN_DNSWL_NONE(0.00)[0.3.8.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.b.8.f.7.0.6.2.list.dnswl.org : 127.0.5.0]; R_SPF_NA(0.00)[]; FORGED_SENDER(0.30)[imp@bsdimp.com,wlosh@bsdimp.com]; FREEMAIL_TO(0.00)[gmail.com]; MIME_TRACE(0.00)[0:+,1:+,2:~]; IP_SCORE(-2.83)[ip: (-9.34), ipnet: 2607:f8b0::/32(-2.60), asn: 15169(-2.18), country: US(-0.05)]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; FROM_NEQ_ENVFROM(0.00)[imp@bsdimp.com,wlosh@bsdimp.com]; RCVD_TLS_ALL(0.00)[]; RCVD_COUNT_TWO(0.00)[2] Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 27 Sep 2019 00:29:30 -0000 This is a developer only option. Out-of-tree consumers would need to be compiled with the kernel directory, much like they would need to be for other things. You wouldn't run a system with this normally: it's only to debug specific instances of bad behavior. I think, like other debugging options, that it's fine. Warner On Thu, Sep 26, 2019 at 6:18 PM Ryan Stone wrote: > Is this enough? Won't out-of-tree modules get compiled without > EPOCH_TRACE set? If such a module is loaded on a kernel with > EPOCH_TRACE set then the module will call epoch_enter_preempt() with a > epoch_tracker that is too small and have its stack corrupted, won't > it? > > On Thu, Sep 26, 2019 at 5:12 PM Gleb Smirnoff wrote: > > > > Author: glebius > > Date: Thu Sep 26 21:12:47 2019 > > New Revision: 352778 > > URL: https://svnweb.freebsd.org/changeset/base/352778 > > > > Log: > > Move EPOCH_TRACE to opt_global.h, so that any external modules that > > use epoch don't need Makefile tweaks. > > > > The downside is that any developer who wants EPOCH_TRACE needs to > > rebuild kernel in full, but that's fine. > > > > Reviewed by: imp > > > > Modified: > > head/sys/conf/options > > head/sys/sys/epoch.h > > > > Modified: head/sys/conf/options > > > ============================================================================== > > --- head/sys/conf/options Thu Sep 26 21:06:55 2019 (r352777) > > +++ head/sys/conf/options Thu Sep 26 21:12:47 2019 (r352778) > > @@ -712,7 +712,7 @@ WITNESS_SKIPSPIN opt_witness.h > > WITNESS_COUNT opt_witness.h > > OPENSOLARIS_WITNESS opt_global.h > > > > -EPOCH_TRACE opt_epoch.h > > +EPOCH_TRACE opt_global.h > > > > # options for ACPI support > > ACPI_DEBUG opt_acpi.h > > > > Modified: head/sys/sys/epoch.h > > > ============================================================================== > > --- head/sys/sys/epoch.h Thu Sep 26 21:06:55 2019 (r352777) > > +++ head/sys/sys/epoch.h Thu Sep 26 21:12:47 2019 (r352778) > > @@ -41,8 +41,6 @@ typedef struct epoch_context *epoch_context_t; > > #include > > #include > > > > -#include "opt_epoch.h" > > - > > struct epoch; > > typedef struct epoch *epoch_t; > > >