From owner-cvs-all Thu Sep 26 16:10:11 2002 Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 5788537B401; Thu, 26 Sep 2002 16:10:10 -0700 (PDT) Received: from wantadilla.lemis.com (wantadilla.lemis.com [192.109.197.80]) by mx1.FreeBSD.org (Postfix) with ESMTP id B595743E6A; Thu, 26 Sep 2002 16:10:08 -0700 (PDT) (envelope-from grog@lemis.com) Received: by wantadilla.lemis.com (Postfix, from userid 1004) id 319178147C; Fri, 27 Sep 2002 08:40:05 +0930 (CST) Date: Fri, 27 Sep 2002 08:40:05 +0930 From: Greg 'groggy' Lehey To: Ruslan Ermilov Cc: Juli Mallett , cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/usr.bin/make parse.c Message-ID: <20020926231005.GS10532@wantadilla.lemis.com> References: <200209260644.g8Q6iUiv000195@freefall.freebsd.org> <20020926085038.GB9743@sunbay.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20020926085038.GB9743@sunbay.com> User-Agent: Mutt/1.4i Organization: The FreeBSD Project Phone: +61-8-8388-8286 Fax: +61-8-8388-8725 Mobile: +61-418-838-708 WWW-Home-Page: http://www.FreeBSD.org/ X-PGP-Fingerprint: 9A1B 8202 BCCE B846 F92F 09AC 22E6 F290 507A 4223 Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Thursday, 26 September 2002 at 11:50:38 +0300, Ruslan Ermilov wrote: > On Wed, Sep 25, 2002 at 11:44:30PM -0700, Juli Mallett wrote: >> jmallett 2002/09/25 23:44:30 PDT >> >> Modified files: >> usr.bin/make parse.c >> Log: >> Remove a semicolon that appears to be a lie. >> >> Spotted by: SPARC64 make WARNS=3 >> Sponsored by: Rachel Hestilow >> >> Revision Changes Path >> 1.43 +1 -1 src/usr.bin/make/parse.c >> > As an aside. Our make(1) suffers from the parsing bug in > parse.c:ParseReadLine(). When it sees a colon (`:') it > marks the line as being a "dependency" line, and when it > later sees a semicolon (`;') it replaces it by a newline. > The net effect is that the following fragment blows up: > > ... > > In OpenBSD, this has been fixed yet in 2001 by the new parsing code > (parse.c,v 1.59 and related changes). What's stopping you from importing the fix? Greg -- See complete headers for address and phone numbers To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message