From owner-svn-src-head@freebsd.org Wed Feb 27 13:04:41 2019 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 36143151CACB for ; Wed, 27 Feb 2019 13:04:41 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Received: from smtp-out-so.shaw.ca (smtp-out-so.shaw.ca [64.59.136.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "Client", Issuer "CA" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id F36F875ADA; Wed, 27 Feb 2019 13:04:38 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Received: from spqr.komquats.com ([70.67.125.17]) by shaw.ca with ESMTPA id yyszgmGIqv0Toyyt0gO0oU; Wed, 27 Feb 2019 06:04:36 -0700 X-Authority-Analysis: v=2.3 cv=Iodgj43g c=1 sm=1 tr=0 a=VFtTW3WuZNDh6VkGe7fA3g==:117 a=VFtTW3WuZNDh6VkGe7fA3g==:17 a=kj9zAlcOel0A:10 a=CFTnQlWoA9kA:10 a=6I5d2MoRAAAA:8 a=YxBL1-UpAAAA:8 a=uj6YtqYK-R6_gwjFUiwA:9 a=CjuIK1q_8ugA:10 a=UJ0tAi3fqDAA:10 a=IjZwj45LgO3ly-622nXo:22 a=Ia-lj3WSrqcvXOmTRaiG:22 Received: from slippy.cwsent.com (slippy [10.1.1.91]) by spqr.komquats.com (Postfix) with ESMTPS id 21EF2B46; Wed, 27 Feb 2019 05:04:31 -0800 (PST) Received: from slippy.cwsent.com (localhost [127.0.0.1]) by slippy.cwsent.com (8.15.2/8.15.2) with ESMTP id x1RD4TD4051904; Wed, 27 Feb 2019 05:04:29 -0800 (PST) (envelope-from Cy.Schubert@cschubert.com) Received: from slippy (cy@localhost) by slippy.cwsent.com (8.15.2/8.15.2/Submit) with ESMTP id x1RD4S6U051477; Wed, 27 Feb 2019 05:04:28 -0800 (PST) (envelope-from Cy.Schubert@cschubert.com) Message-Id: <201902271304.x1RD4S6U051477@slippy.cwsent.com> X-Authentication-Warning: slippy.cwsent.com: cy owned process doing -bs X-Mailer: exmh version 2.8.0 04/21/2012 with nmh-1.7.1 Reply-to: Cy Schubert From: Cy Schubert X-os: FreeBSD X-Sender: cy@cwsent.com X-URL: http://www.cschubert.com/ To: Andriy Gapon cc: Cy Schubert , Baptiste Daroussin , src-committers , svn-src-head@FreeBSD.ORG, Jack Halford Subject: Re: svn commit: r344569 - in head/cddl/contrib/opensolaris: cmd/zfs lib/libzfs/common In-Reply-To: Message from Andriy Gapon of "Wed, 27 Feb 2019 09:12:13 +0200." <0563e72c-c9e3-a476-ce43-d4a67c454508@FreeBSD.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Wed, 27 Feb 2019 05:04:28 -0800 X-CMAE-Envelope: MS4wfGQVuWBPN/nATK74MOclAK5W5NwBDrsQJXZWw2DISiDwBZ7/1PYOV941vHWjvOpbCJM3jbN89OIAI7LO2xLzVe00/3pBlDf6igWoFGBorOIrv6SWYRc+ +C0wm9D2oH8QAQGD9lvREY4+6wlYEgk5wGP7fEF1PB0i7IeiAm/Ba8+pdGOUX9dw+pbl3GvIfFKHhjuABbNrD42dZa4NjzzrmJl8eJ7wtuFUgfsReLOtMvax +E/8WTSUS4XdaZV2evxbNTrzrlbh6mJrRJ26JAM4xfnew3Q7JhtdijbC9JwgqJ6y1RG1YNmsH87pihyyDUPlWQ== X-Rspamd-Queue-Id: F36F875ADA X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-4.66 / 15.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; HAS_REPLYTO(0.00)[Cy.Schubert@cschubert.com]; TO_DN_SOME(0.00)[]; MV_CASE(0.50)[]; HAS_XAW(0.00)[]; RCPT_COUNT_FIVE(0.00)[6]; MX_GOOD(-0.01)[spqr.komquats.com]; NEURAL_HAM_SHORT(-0.95)[-0.947,0]; RCVD_IN_DNSWL_LOW(-0.10)[137.136.59.64.list.dnswl.org : 127.0.5.1]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:6327, ipnet:64.59.128.0/20, country:CA]; RCVD_TLS_LAST(0.00)[]; RECEIVED_SPAMHAUS_PBL(0.00)[17.125.67.70.zen.spamhaus.org : 127.0.0.11]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-0.999,0]; RCVD_COUNT_FIVE(0.00)[5]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; REPLYTO_EQ_FROM(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[text/plain]; IP_SCORE(-2.01)[ip: (-5.22), ipnet: 64.59.128.0/20(-2.66), asn: 6327(-2.08), country: CA(-0.09)]; TO_MATCH_ENVRCPT_SOME(0.00)[]; R_SPF_NA(0.00)[] X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 27 Feb 2019 13:04:41 -0000 In message <0563e72c-c9e3-a476-ce43-d4a67c454508@FreeBSD.org>, Andriy Gapon wri tes: > On 26/02/2019 22:58, Cy Schubert wrote: > > I was talking about nested datasets, i.e. tank/freebsd/git/current and > > tank/freebsd/git/ports are four levels deep. > > We usually don't call them "nested". In fact, I don't think that we call the > m > anything special because having N levels deep datasets (N > 1) is just a comm > on > thing. We may call them subordinate or child datasets when mentioning a > relation to a parent dataset. > > > In my case the ports > > dataset was mounted while the current dataset was not, though zfs > > believed it was. unmounting the current dataset and remounting it, zfs > > umount .../current; zfs mount .../current worked around the issue. > > Are you sure that it was not mounted? Yes. > Have you checked that by looking at mount output? Yes > I suspect that it was mounted, just not where you expected and its mount path > was covered by another filesystem. If you read my original email a zfs umount followed by a zfs mount for each affected filesystem worked around the problem. zfs properties showed that each and every filesystem was mounted. mount(1) and df(1) confirmed they were not. Furthermore nullfs mounts with the late attribute failed to mount because their underlying zfs datasets were not mounted -- this is what clued me into the problem in the first place, a FreeBSD system dropping into single user at boot. And, no, fstab on that machine had not been changed for months, them machine failed to boot. So, no, I was not mistaken. I was rather displeased because I had to try to fix the problem using ssh on a phone to a machine connected to a console server. > > E.g., lets consider this hypothetical case. > I have two same level datasets tank/freebsd/src and tank/freebsd/sys where > tank/freebsd/src is mounted at /usr/src and tank/freebsd/sys is mounted at > /usr/src/sys (a child directory of /usr/src). > If tank/freebsd/src is mounted first, then everything is okay, tank/freebsd/s > ys > would be mounted on top of sys directory in tank/freebsd/src. > If, however, tank/freebsd/sys is mounted first (assuming that path /usr/src/s > ys > exists in a root filesystem), then mounting tank/freebsd/src would simply hid > e > tank/freebsd/sys "below" it as /usr/src/sys would be sys directory in > tank/freebsd/src. > > I guess that this is a kind of problem that could be introduced with parallel > mounting. And I guess that this is a kind of problem that you might actually > have. But it's just a guess. No. I had not mistakenly mounted the datasets elsewhere, mistakenly deleted them or mistakenly changed their mount attributes. It was a real, not imagined, regression fixed by the patch posted near the end of the email thread. -- Cheers, Cy Schubert FreeBSD UNIX: Web: http://www.FreeBSD.org The need of the many outweighs the greed of the few.