Date: Thu, 24 Jun 2004 00:39:33 +0200 (CEST) From: Jean-Yves Lefort <jylefort@brutele.be> To: FreeBSD-gnats-submit@FreeBSD.org Subject: ports/68256: bsd.gnome.mk locale patch is incomplete Message-ID: <20040623223933.084D522E28@jsite.lefort.net> Resent-Message-ID: <200406232240.i5NMeHFL010645@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 68256
>Category: ports
>Synopsis: bsd.gnome.mk locale patch is incomplete
>Confidential: no
>Severity: non-critical
>Priority: medium
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: change-request
>Submitter-Id: current-users
>Arrival-Date: Wed Jun 23 22:40:17 GMT 2004
>Closed-Date:
>Last-Modified:
>Originator: Jean-Yves Lefort
>Release: FreeBSD 4.10-RELEASE i386
>Organization:
>Environment:
System: FreeBSD jsite.lefort.net 4.10-RELEASE FreeBSD 4.10-RELEASE #0: Thu May 27 14:42:30 CEST 2004 jylefort@jsite.lefort.net:/usr/obj/usr/src/sys/JSITE i386
>Description:
The gnomehack component of bsd.gnome.mk fixes the locale path in the
Makefile.in files.
However, for most programs the locale path also needs to be patched in
the configure scripts, since it's the place from where the path is
hardwired into the program.
Failing to do so results in a program trying to find its translations
in the wrong location, and the problem is likely to stay unnoticed.
The attached patch fixes the issue.
WARNING: some ports already fix that themselves by the mean of a
configure patch. These ports will break if this patch is committed,
therefore I suggest to mail the maintainers of all the ports using
USE_GNOME=gnomehack and having a configure patch, asking them to fix
their port(s).
>How-To-Repeat:
>Fix:
--- bsd.gnome.mk.orig Thu Jun 24 00:02:27 2004
+++ bsd.gnome.mk Thu Jun 24 00:02:34 2004
@@ -59,7 +59,9 @@
s|[(]libdir[)]/bonobo/servers|(prefix)/libdata/bonobo/servers|g' ; \
${FIND} ${WRKSRC} -name "configure" | ${XARGS} ${REINPLACE_CMD} -e \
's|-lpthread|${PTHREAD_LIBS}|g ; \
- s|DATADIRNAME=lib|DATADIRNAME=share|g'
+ s|DATADIRNAME=lib|DATADIRNAME=share|g ; \
+ s|{datadir}/locale|{prefix}/share/locale|g ; \
+ s|{libdir}/locale|{prefix}/share/locale|g'
lthack_PRE_PATCH= ${FIND} ${WRKSRC} -name "configure" | ${XARGS} ${REINPLACE_CMD} -e \
'/^LIBTOOL_DEPS="$$ac_aux_dir\/ltmain.sh"$$/s|$$|; $$ac_aux_dir/ltconfig $$LIBTOOL_DEPS;|'
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20040623223933.084D522E28>