From owner-svn-src-all@freebsd.org  Sun Oct 25 18:14:24 2020
Return-Path: <owner-svn-src-all@freebsd.org>
Delivered-To: svn-src-all@mailman.nyi.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.nyi.freebsd.org (Postfix) with ESMTP id D40E6454F76;
 Sun, 25 Oct 2020 18:14:24 +0000 (UTC) (envelope-from pfg@FreeBSD.org)
Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256
 client-signature RSA-PSS (4096 bits) client-digest SHA256)
 (Client CN "smtp.freebsd.org",
 Issuer "Let's Encrypt Authority X3" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id 4CK5hc5Hh8z4Md7;
 Sun, 25 Oct 2020 18:14:24 +0000 (UTC) (envelope-from pfg@FreeBSD.org)
Received: from [192.168.0.2] (unknown [181.52.72.201])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (Client did not present a certificate) (Authenticated sender: pfg)
 by smtp.freebsd.org (Postfix) with ESMTPSA id 163631AA68;
 Sun, 25 Oct 2020 18:14:23 +0000 (UTC) (envelope-from pfg@FreeBSD.org)
Subject: Re: svn commit: r366993 - head/sys/net
To: Ed Maste <emaste@freebsd.org>, Warner Losh <imp@bsdimp.com>
Cc: "src-committers@freebsd.org" <src-committers@freebsd.org>,
 "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>,
 "svn-src-head@freebsd.org" <svn-src-head@freebsd.org>
References: <202010241023.09OANMcL075640@repo.freebsd.org>
 <20201024125206.GB38000@FreeBSD.org>
 <999a005e-1ef8-3c45-fb07-94a3b6ebce1b@selasky.org>
 <317231603546378@mail.yandex.ru>
 <CANCZdfq8NH=rspaugts=W0Uu183pDcVvOK8oGh6kCvfpkM-=Ww@mail.gmail.com>
 <CAPyFy2Coiyz1CYGGLD3QS1M-6Q4Hc38WNcXA+KvRbuTAhmMvcA@mail.gmail.com>
From: Pedro Giffuni <pfg@FreeBSD.org>
Organization: FreeBSD
Message-ID: <7d769528-9c00-7096-11f3-4bcd751dcb05@FreeBSD.org>
Date: Sun, 25 Oct 2020 13:14:22 -0500
User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:78.0) Gecko/20100101
 Thunderbird/78.4.0
MIME-Version: 1.0
In-Reply-To: <CAPyFy2Coiyz1CYGGLD3QS1M-6Q4Hc38WNcXA+KvRbuTAhmMvcA@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.33
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all/>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 25 Oct 2020 18:14:24 -0000

On 10/24/20 8:19 PM, Ed Maste wrote:
> On Sat, 24 Oct 2020 at 11:27, Warner Losh <imp@bsdimp.com> wrote:
>>> Given we already have nice .clang-format, that does most of the job, maybe it's worth considering looking into tweaking it further to fix this part?
>>> It would be nice if we could finally offload all formatting issues to the tool and focus on the actual code :-)
>> It would be nice if it produced one of the style(9) acceptable formats without disrupting things already acceptable.  That's been the big problem with the tweaks to date... some things are fixed, others break. It's getting a lot closer, though
> Upstream clang-format comes with a script that can integrate with git,
> adding a `git clang-format` command. It will apply formatting to
> modified lines, leaving unchanged ones alone.

I doubt any script can match style(9) perfectly. indent(1) with bde's 
flags came near in some edge cases but generally did a horrible job. 
Also, out style(9) is not mandatory for userland.

Pedro.