From owner-svn-src-head@freebsd.org Wed Mar 1 15:54:59 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id C233ECE40A7 for ; Wed, 1 Mar 2017 15:54:59 +0000 (UTC) (envelope-from ian@freebsd.org) Received: from pmta2.delivery6.ore.mailhop.org (pmta2.delivery6.ore.mailhop.org [54.200.129.228]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id A640E73 for ; Wed, 1 Mar 2017 15:54:59 +0000 (UTC) (envelope-from ian@freebsd.org) X-MHO-User: 5650a952-fe97-11e6-b3c2-c9f38144898e X-Report-Abuse-To: https://support.duocircle.com/support/solutions/articles/5000540958-duocircle-standard-smtp-abuse-information X-Originating-IP: 73.78.92.27 X-Mail-Handler: DuoCircle Outbound SMTP Received: from ilsoft.org (unknown [73.78.92.27]) by outbound2.ore.mailhop.org (Halon) with ESMTPSA id 5650a952-fe97-11e6-b3c2-c9f38144898e; Wed, 01 Mar 2017 15:54:22 +0000 (UTC) Received: from rev (rev [172.22.42.240]) by ilsoft.org (8.15.2/8.15.2) with ESMTP id v21FspSv006786; Wed, 1 Mar 2017 08:54:51 -0700 (MST) (envelope-from ian@freebsd.org) Message-ID: <1488383691.60166.12.camel@freebsd.org> Subject: Re: svn commit: r314464 - head/usr.sbin/yppush From: Ian Lepore To: "Rodney W. Grimes" , "Ngie Cooper (yaneurabeya)" Cc: Ngie Cooper , src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Date: Wed, 01 Mar 2017 08:54:51 -0700 In-Reply-To: <201703010553.v215rfIj054071@pdx.rh.CN85.dnsmgr.net> References: <201703010553.v215rfIj054071@pdx.rh.CN85.dnsmgr.net> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.18.5.1 FreeBSD GNOME Team Port Mime-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 01 Mar 2017 15:54:59 -0000 On Tue, 2017-02-28 at 21:53 -0800, Rodney W. Grimes wrote: > -- Start of PGP signed section. > [ Charset UTF-8 unsupported, converting... ] > > > > > > > > > > On Feb 28, 2017, at 21:38, Rodney W. Grimes > > N85.dnsmgr.net> wrote: > > > > > > Would it be possible to not do this as 1000 commits? > > Yes, but I?m trying to do this in a way that allows me to > > backport all of the changes as easily as possible to ^/stable/10 > > (on the other side of the coin, I?ve run into dependent commits of > > other MFCs that required sweeping changes in order to make my > > changes possible). > > I do think your point is valid though and I can probably strike > > some middle ground with my changes. I think grouping it up by 2nd > > level directory (like I did with usr.bin/svn) makes the most sense. > > Thank you, > Yes, that is what I was thinking.  Note that I dont agree with this > change, > but I have probably missed a discussion that is allowing it to move > forward. > It makes the logfiles of make output now src tree possition > dependent, > but I am probalby the only person in the universe that has ever run a > diff on the output of make world. > > It may also be possible to split this into some phases to reduce some > of > your issues, only do the {.CURDIR}/../../foo -> ${SRCTOP}/bar/foo in > one pass and > some of the other fixes in another pass. > > You're not the only one who has diffed build output logs (I suspect anyone who has to maintain a non-trivial build infrastructure has done so), and you're not the only one who thinks that changing relative paths to absolute is a bad idea. -- Ian