Date: Thu, 22 Dec 2011 19:27:05 +0100 From: =?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?= <des@des.no> To: Gleb Smirnoff <glebius@FreeBSD.org> Cc: svn-src-all@FreeBSD.org, src-committers@FreeBSD.org, svn-src-vendor@FreeBSD.org Subject: Re: svn commit: r228809 - vendor/openpam/dist/lib Message-ID: <86bor0sbra.fsf@ds4.des.no> In-Reply-To: <20111222182219.GS80057@FreeBSD.org> (Gleb Smirnoff's message of "Thu, 22 Dec 2011 22:22:19 %2B0400") References: <201112221810.pBMIAFlo028054@svn.freebsd.org> <20111222182219.GS80057@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Gleb Smirnoff <glebius@FreeBSD.org> writes:
> I haven't yet tested this, but code looks like it is not going to print
> anything in a case I don't have /usr/local/bin/pam_foo.so, while purpose
> of the patch is to avoid logging of failure to open
> /usr/local/bin/pam_foo.so.5.
>
> Although openpam_dynamic() will do some logging of errno value, the name
> of the failed file won't be logged. If I got a lot of modules configured,
> then I can't figure out which one is ENOENT.
>
> IMHO, some no_log flag should be passed down from the try_dlopen() to fix
> the issue correctly.
Index: openpam_dynamic.c
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
--- openpam_dynamic.c (revision 509)
+++ openpam_dynamic.c (working copy)
@@ -124,7 +124,7 @@
dlclose(dlh);
FREE(module);
err:
- openpam_log(PAM_LOG_ERROR, "%m");
+ openpam_log(PAM_LOG_ERROR, "%s: %m", path);
return (NULL);
}
=20
DES
--=20
Dag-Erling Sm=C3=B8rgrav - des@des.no
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?86bor0sbra.fsf>