From owner-svn-src-head@FreeBSD.ORG  Sun Feb 28 21:59:30 2010
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 4352C106564A;
	Sun, 28 Feb 2010 21:59:30 +0000 (UTC) (envelope-from imp@bsdimp.com)
Received: from harmony.bsdimp.com (bsdimp.com [199.45.160.85])
	by mx1.freebsd.org (Postfix) with ESMTP id F1C9C8FC13;
	Sun, 28 Feb 2010 21:59:29 +0000 (UTC)
Received: from localhost (localhost [127.0.0.1])
	by harmony.bsdimp.com (8.14.3/8.14.1) with ESMTP id o1SLqkgY036886;
	Sun, 28 Feb 2010 14:52:46 -0700 (MST) (envelope-from imp@bsdimp.com)
Date: Sun, 28 Feb 2010 14:53:00 -0700 (MST)
Message-Id: <20100228.145300.29649867912530.imp@bsdimp.com>
To: peterjeremy@acm.org
From: "M. Warner Losh" <imp@bsdimp.com>
In-Reply-To: <20100228195041.GA68446@server.vk2pj.dyndns.org>
References: <20100226132854.GA25722@sandvine.com>
	<3bbf2fe11002260557y484cf13bq76f7507c07ed3ebc@mail.gmail.com>
	<20100228195041.GA68446@server.vk2pj.dyndns.org>
X-Mailer: Mew version 6.3 on Emacs 22.3 / Mule 5.0 (SAKAKI)
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Cc: src-committers@FreeBSD.org, delphij@gmail.com, svn-src-all@FreeBSD.org,
	attilio@FreeBSD.org, kostikbel@gmail.com,
	svn-src-head@FreeBSD.org, emaste@FreeBSD.org
Subject: Re: svn commit: r204309 - in head/sys: amd64/amd64 amd64/isa conf
 i386/bios i386/cpufreq i386/i386 i386/isa i386/xen isa modules/bios/smbios
 modules/bios/vpd modules/cpufreq pc98/pc98 x86 x86/bios x86/...
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
	<svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 28 Feb 2010 21:59:30 -0000

In message: <20100228195041.GA68446@server.vk2pj.dyndns.org>
            Peter Jeremy <peterjeremy@acm.org> writes:
: On 2010-Feb-26 14:57:36 +0100, Attilio Rao <attilio@freebsd.org> wrote:
: >For the future, however, probabilly we would need to do something like
: >pc98 already does wrt i386 (i386/include/ pc98/include/ amd64/include/
: >just have files wrappers to the generic one under x86/include/ when
: >necessary).
: 
: Not that something like this is also critical for getting i386/amd64
: cross compilation to work - one of the blocking issues is that the
: correct machine/ includes are not available in cross-compilatio mode.

Huh?

I cross build all the time, and the machine/ includes are always
right, with or without this patch.  Maybe you could explain what you
mean here...

The issue is that old code has

#include <i386/isa.h>

or whatever in it, and we need to have an i386/isa.h that's just
#include <x86/isa.h>

Warner