From owner-svn-src-all@FreeBSD.ORG Wed Mar 11 04:09:20 2009 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 7F1EE106566B; Wed, 11 Mar 2009 04:09:20 +0000 (UTC) (envelope-from ota@j.email.ne.jp) Received: from mail2.asahi-net.or.jp (mail2.asahi-net.or.jp [202.224.39.198]) by mx1.freebsd.org (Postfix) with ESMTP id 16C508FC16; Wed, 11 Mar 2009 04:09:20 +0000 (UTC) (envelope-from ota@j.email.ne.jp) Received: from localhost (pool-70-20-228-87.phil.east.verizon.net [70.20.228.87]) by mail2.asahi-net.or.jp (Postfix) with ESMTP id E0CA96F7DE; Wed, 11 Mar 2009 12:51:12 +0900 (JST) Date: Tue, 10 Mar 2009 23:51:10 -0400 From: Yoshihiro Ota To: Guido van Rooij , Fabian Keil , svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, phk@freebsd.org Message-Id: <20090310235110.c0c6f71e.ota@j.email.ne.jp> In-Reply-To: <20090310180157.GA4663@gvr.gvr.org> References: <200903101523.n2AFNhs1065867@svn.freebsd.org> <20090310171948.1ac51696@fabiankeil.de> <20090310180157.GA4663@gvr.gvr.org> X-Mailer: Sylpheed 2.6.0 (GTK+ 2.12.11; i386-portbld-freebsd7.1) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: Subject: Re: svn commit: r189625 - head/sys/geom/eli X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 11 Mar 2009 04:09:21 -0000 On Tue, 10 Mar 2009 19:01:57 +0100 Guido van Rooij wrote: > On Tue, Mar 10, 2009 at 05:19:48PM +0100, Fabian Keil wrote: > > > Log: > > > When attaching a geli on boot make sure that it is detached > > > upon last close. (needed for a gmirror to properly shutdown > > > upon reboot when a geli is on top the gmirror) > > > > > > > Detach-on-last-close is known to cause panics when > > scrubbing at least some ZFS pools: > > http://www.freebsd.org/cgi/query-pr.cgi?pr=kern/117158 > > > > Quoting the PR: > > |Quoting Pawel Jakub Dawidek's response to my initial report: > > ||GELI's detach-on-last-close mechanism is a general purpose mechanism, it > > ||may not work correctly with ZFS, because ZFS sometimes closes and reopen > > ||providers, which will make GELI to detach. In other words you shouldn't > > ||configure detach-on-last-close for ZFS components. > > > > Grr. So we should make it tuneable. How about being able to set > this flag with the geli command, like the G_ELI_FLAG_BOOT flag. > > -Guido Can we move its implementation into the GEOM framwork such that all of GEOM classes can have detach-on-last-close? It will need some kind of custom hook such that each class can do something extra, i.e. gjournal sync. I often need to stop providers to securely detach USB disks. Hiro