From nobody Wed Mar 22 19:35:46 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4PhdxG6ntXz41D0x; Wed, 22 Mar 2023 19:35:46 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4PhdxG5P6Gz4DQh; Wed, 22 Mar 2023 19:35:46 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1679513746; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=7ecXVVKdbZzozdQivX0/udrp8V3rqA9+KO4vrGpODSE=; b=BCtD+NdeR/re3A+oc+uNx4+lWt8pw7Fof1MvV4jzU6yUOauRQ6Rl4XCSUFEGPxllloPHp4 q0YRBv20TuSOwsNTEnZw6juncMSiI8+CMNXJW0R/Fpm3TL9TrWHn1a3loDOpTKjLn1bvum tfC1Xa/UuF9eBKVVHxeKoZ5Sr9rIYWuATIv6jTv88Sr2Jc3rw3qZveatveqUN2eSon0ROS xWfKNA+sbw8jxOBItpjTE00mRd58eYJIsJMiuqTXoo5Rgg7nkLiqq+Av6/YIsuVzap370U Pz3kHbjdAE9m1KFL4+T0wv7MprqNZxw8FsGV4A381rS59TsW7fO0nnyj2zmc4g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1679513746; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=7ecXVVKdbZzozdQivX0/udrp8V3rqA9+KO4vrGpODSE=; b=dlm/npqryhhrWpe8N8dXWpUtL4pwVuEBLrHbNfJ++9o+N0TllMXdHxZ1KQJ35brdZYcXo9 4yTPNOGQxvaltekskyDBxaMkDoQ0votCT3+Vik239ctTfeKjcG6XesoousEtm6e29whorP KOQsVa084te04mylDNzKRXsWpTAYPpAnFwfi6chPiK8/l9TIAgFu0z5SYo9G44Rh9uya9s u6ELnhYFpXW2ZWnn4ZvDzQrBDMBz4pqBs5zrPiEvrPgr2Xw1K92wFP/kJ42vp/lcOUCeOi sdr0kcty8doUdTfMZRu4VVwLgH0gS7R/+Dp4LViGahTXNxdR9oa5JzuAK4twRw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1679513746; a=rsa-sha256; cv=none; b=QBMaWwN14MPsCBWcJLihmEGp+HHeyTstSxkbfaGf8zYURBOwCuCB6dg+hfxXIK2jljpN+y 0jgaV0msAz6u7+3qZTs/TSHFun249ugNkjA3Cskekp+xHuFURqfaidrjebyNvObcI08qrO 8LBjHPWF2r9pTdQFED08Zyt6lsRPwFf+M2VNKe1pCd85fvZ8UfthO6ZzgG2yL/AFwaKZLc WFxJDuV5u/PcnyS3E+A+U1KBJHUp+WLm/l34rgHeXQp18VxvZJ9KIFvkiMX8CefPbQA7Xp yn9KWyZaaQjK6cOb3thEZw+3d+5SKutwesvRvrMf5XHduEYKXOXrpMX04WQP7Q== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4PhdxG4VtSz15bf; Wed, 22 Mar 2023 19:35:46 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 32MJZkHK019748; Wed, 22 Mar 2023 19:35:46 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 32MJZkRa019747; Wed, 22 Mar 2023 19:35:46 GMT (envelope-from git) Date: Wed, 22 Mar 2023 19:35:46 GMT Message-Id: <202303221935.32MJZkRa019747@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: John Baldwin Subject: git: 48c519be0e80 - main - libpfctl: Don't pass stack garbage to free. List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: jhb X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 48c519be0e8005aedc817b1bc1101ad32b67a67a Auto-Submitted: auto-generated X-ThisMailContainsUnwantedMimeParts: N The branch main has been updated by jhb: URL: https://cgit.FreeBSD.org/src/commit/?id=48c519be0e8005aedc817b1bc1101ad32b67a67a commit 48c519be0e8005aedc817b1bc1101ad32b67a67a Author: John Baldwin AuthorDate: 2023-03-22 19:33:59 +0000 Commit: John Baldwin CommitDate: 2023-03-22 19:33:59 +0000 libpfctl: Don't pass stack garbage to free. GCC 9 on stable/12 reports a -Wmaybe-uninitialized error for the call to free in _pfctl_clear_states. Reviewed by: mjg Differential Revision: https://reviews.freebsd.org/D39198 --- lib/libpfctl/libpfctl.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/lib/libpfctl/libpfctl.c b/lib/libpfctl/libpfctl.c index f95f79024bf5..f34f83cfb57c 100644 --- a/lib/libpfctl/libpfctl.c +++ b/lib/libpfctl/libpfctl.c @@ -1188,7 +1188,6 @@ static int _pfctl_clear_states(int dev, const struct pfctl_kill *kill, unsigned int *killed, uint64_t ioctlval) { - struct pfioc_nv nv; nvlist_t *nvl; int ret; @@ -1211,7 +1210,6 @@ _pfctl_clear_states(int dev, const struct pfctl_kill *kill, *killed = nvlist_get_number(nvl, "killed"); nvlist_destroy(nvl); - free(nv.data); return (ret); }