From owner-p4-projects@FreeBSD.ORG  Fri Oct 13 19:59:13 2006
Return-Path: <owner-p4-projects@FreeBSD.ORG>
X-Original-To: p4-projects@freebsd.org
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id 685D916A4DA; Fri, 13 Oct 2006 19:59:13 +0000 (UTC)
X-Original-To: perforce@freebsd.org
Delivered-To: perforce@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 4301516A4D2;
	Fri, 13 Oct 2006 19:59:13 +0000 (UTC) (envelope-from jhb@freebsd.org)
Received: from server.baldwin.cx (66-23-211-162.clients.speedfactory.net
	[66.23.211.162])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 0766D43D60;
	Fri, 13 Oct 2006 19:59:10 +0000 (GMT) (envelope-from jhb@freebsd.org)
Received: from localhost.corp.yahoo.com (john@localhost [127.0.0.1])
	(authenticated bits=0)
	by server.baldwin.cx (8.13.6/8.13.6) with ESMTP id k9DJwuvR017283;
	Fri, 13 Oct 2006 15:59:08 -0400 (EDT) (envelope-from jhb@freebsd.org)
From: John Baldwin <jhb@freebsd.org>
To: Paolo Pisati <piso@freebsd.org>
Date: Fri, 13 Oct 2006 15:58:07 -0400
User-Agent: KMail/1.9.1
References: <200610131200.k9DC0ajd097822@repoman.freebsd.org>
In-Reply-To: <200610131200.k9DC0ajd097822@repoman.freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-15"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200610131558.07530.jhb@freebsd.org>
X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by
	milter-greylist-2.0.2 (server.baldwin.cx [127.0.0.1]);
	Fri, 13 Oct 2006 15:59:08 -0400 (EDT)
X-Virus-Scanned: ClamAV 0.88.3/2030/Fri Oct 13 09:34:34 2006 on
	server.baldwin.cx
X-Virus-Status: Clean
X-Spam-Status: No, score=-4.4 required=4.2 tests=ALL_TRUSTED,AWL,BAYES_00 
	autolearn=ham version=3.1.3
X-Spam-Checker-Version: SpamAssassin 3.1.3 (2006-06-01) on server.baldwin.cx
Cc: Perforce Change Reviews <perforce@freebsd.org>
Subject: Re: PERFORCE change 107815 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 13 Oct 2006 19:59:13 -0000

On Friday 13 October 2006 08:00, Paolo Pisati wrote:
> http://perforce.freebsd.org/chv.cgi?CH=107815
> 
> Change 107815 by piso@piso_newluxor on 2006/10/13 12:00:35
> 
> 	Fixes compilation of GENERIC on amd64.

It would be better to fix the functions to return an appropriate value.

> Affected files ...
> 
> .. //depot/projects/soc2006/intr_filter/amd64/isa/clock.c#6 edit
> 
> Differences ...
> 
> ==== //depot/projects/soc2006/intr_filter/amd64/isa/clock.c#6 (text+ko) ====
> 
> @@ -758,7 +758,7 @@
>  	 * timecounter to user a simpler algorithm.
>  	 */
>  	if (!using_lapic_timer) {
> -		intr_add_handler("clk", 0, clkintr, NULL, NULL,
> +		intr_add_handler("clk", 0, (driver_filter_t *)clkintr, NULL, NULL,
>  		    INTR_TYPE_CLK, NULL);
>  		i8254_intsrc = intr_lookup_source(0);
>  		if (i8254_intsrc != NULL)
> @@ -792,7 +792,7 @@
>  
>  		/* Enable periodic interrupts from the RTC. */
>  		rtc_statusb |= RTCSB_PINTR;
> -		intr_add_handler("rtc", 8, rtcintr, NULL, NULL,
> +		intr_add_handler("rtc", 8, (driver_filter_t *)rtcintr, NULL, NULL,
>  		    INTR_TYPE_CLK, NULL);
>  
>  		writertc(RTC_STATUSB, rtc_statusb);
> 

-- 
John Baldwin