Date: Fri, 24 Sep 2004 22:16:39 +0400 From: Igor Pokrovsky <ip@doom.homeunix.org> To: Thierry Thomas <thierry@FreeBSD.org> Cc: freebsd-ports-bugs@FreeBSD.org Subject: Re: ports/72002: Update port: graphics/deng dependency fix Message-ID: <20040924181639.GA10471@doom.homeunix.org> In-Reply-To: <200409231915.i8NJFRKA049951@freefall.freebsd.org> References: <200409231915.i8NJFRKA049951@freefall.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Sep 23, 2004 at 07:15:27PM +0000, Thierry Thomas wrote:
> Synopsis: Update port: graphics/deng dependency fix
>
> State-Changed-From-To: open->feedback
> State-Changed-By: thierry
> State-Changed-When: Thu Sep 23 19:10:58 GMT 2004
> State-Changed-Why:
>
> - this port uses LIBTOOL;
>
> - <bsd.port.pre.mk> is no more required;
>
> - fix WITH_OPENAL case.
>
> I propose you the following patch:
Thierry,
You are right. Your patch is fine. Commit it please.
However I have a question. Why bsd.port.pre.mk is not required in this case.
I thought that we need it to resolve ${LOCALBASE} on the early stage.
Am I wrong?
And another thing. I used BUILD_DEPENDS and RUN_DEPENDS together instead
of simply LIB_DEPENDS because AFAIR portlint was complaining about
placing LIB_DEPENDS so late in makefile. So I see it's not the case now?
-ip
--
Do whatever your enemies don't want you to do.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20040924181639.GA10471>