From owner-cvs-all@FreeBSD.ORG Thu Jan 24 21:11:17 2008 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id BDF2F16A47B for ; Thu, 24 Jan 2008 21:11:17 +0000 (UTC) (envelope-from kip.macy@gmail.com) Received: from wa-out-1112.google.com (wa-out-1112.google.com [209.85.146.179]) by mx1.freebsd.org (Postfix) with ESMTP id 8806713C455 for ; Thu, 24 Jan 2008 21:11:17 +0000 (UTC) (envelope-from kip.macy@gmail.com) Received: by wa-out-1112.google.com with SMTP id k17so612861waf.3 for ; Thu, 24 Jan 2008 13:11:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; bh=jMmTsvbz+ZZKgK7HgbP8kTrJHE1aYzrdyVXI7wsMEQg=; b=fZIq1ySfwb9hwqojtlv7okocbiJQCzBZ7J+1afQL0RSDMXxa86jGOGIcMh/ssEoU5GH3HYpRl9hFw5j/xjwDLE3hlj/D9k3MMXvhpHMycnU14q8xxgacIvxle3CVCcOcwZEW/3Nee61Wye+UHZhBrujQJrmK7hw9bb/cvX9mVf8= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=iW9FTC39HkJE8O0z7DFBkGqXAKZgQtm9OOV5RfEvvbJTUnbfzT4k0PfJ7gLQfc6VQYQqfvQDIou87Cy3MDWKDowkR4tPXm0JSlktE9LnBJNLzn0m9oTSIBh5B0Gh3xOnWisYU4fuK8SFXrmJPHAkpiC3gp82Ba0pidtIXr6OaiI= Received: by 10.115.74.1 with SMTP id b1mr1320229wal.93.1201209076301; Thu, 24 Jan 2008 13:11:16 -0800 (PST) Received: by 10.114.255.16 with HTTP; Thu, 24 Jan 2008 13:11:16 -0800 (PST) Message-ID: Date: Thu, 24 Jan 2008 13:11:16 -0800 From: "Kip Macy" To: "Andre Oppermann" In-Reply-To: <47986F4D.6070208@freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <200711200656.lAK6u4bc021279@repoman.freebsd.org> <4797B77E.2090605@freebsd.org> <47986F4D.6070208@freebsd.org> Cc: Mike Silbersack , kmacy@freebsd.org, cvs-src@freebsd.org, cvs-all@freebsd.org, src-committers@freebsd.org, freebsd-net@freebsd.org Subject: Re: cvs commit: src/sys/netinet tcp_syncache.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 24 Jan 2008 21:11:17 -0000 Whatever, just run all future changes by silby. On Jan 24, 2008 2:58 AM, Andre Oppermann wrote: > Kip Macy wrote: > > Did you talk to the original submitter? Note that FreeBSD's TCP stack > > is for use in servers and is not intending as a validating TCP stack. > > If you would like it to serve as such you would better served by > > tracking down the ANVL tests that FreeBSD fails. Also note that there > > is no MUST in the following sentence: > > > > > > "For simplicity and symmetry, we specify that > > timestamps always be sent and echoed in both directions." > > > > So it is clearly open to interpretation. > > No, it is not. RFC1323 was written in 1992 before RFCs contained the > boiler plate definition of MUST, SHOULD, MAY and so on. I, at least > as a non-native English speaker, find the sentence perfectly clear > and without any doubt. The IETF TCPM working group comes to the > same conclusion. And I suppose many native English speakers too. > Despite that arguing over whether "always" lacks a "MUST" to make > it really always always and never not you cited the wrong part of > RFC1323 as reason to completely remove the check. That's what I'm > complaining about. Everyone in FreeBSD, including you and me, should > at least provide the correct citation and rationale for any code > change irrespective of the eventual merit of the change itself which > is a separate issue. > > -- > Andre >