From owner-p4-projects@FreeBSD.ORG  Sat Dec 13 09:03:20 2008
Return-Path: <owner-p4-projects@FreeBSD.ORG>
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id C3D521065673; Sat, 13 Dec 2008 09:03:20 +0000 (UTC)
Delivered-To: perforce@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 54F5E1065672
	for <perforce@freebsd.org>; Sat, 13 Dec 2008 09:03:20 +0000 (UTC)
	(envelope-from hselasky@c2i.net)
Received: from swip.net (mailfe08.swip.net [212.247.154.225])
	by mx1.freebsd.org (Postfix) with ESMTP id DEBF38FC21
	for <perforce@freebsd.org>; Sat, 13 Dec 2008 09:03:19 +0000 (UTC)
	(envelope-from hselasky@c2i.net)
X-Cloudmark-Score: 0.000000 []
X-Cloudmark-Analysis: v=1.0 c=1 a=9QZaWaqL03AA:10
	a=P3SC899gXHkOLDnkTYxLZw==:17 a=6I5d2MoRAAAA:8
	a=hJzKuLrDb6rRpbuRkswA:9 a=dl01UOpP-r3UNllpzWwA:7
	a=FxBZ5948YNcW08clmwfgYjQj7CQA:4 a=LY0hPdMaydYA:10
Received: from [62.113.133.240] (account mc467741@c2i.net [62.113.133.240]
	verified) by mailfe08.swip.net (CommuniGate Pro SMTP 5.2.6)
	with ESMTPA id 1163397365; Sat, 13 Dec 2008 10:03:17 +0100
From: Hans Petter Selasky <hselasky@c2i.net>
To: Sam Leffler <sam@freebsd.org>
Date: Sat, 13 Dec 2008 10:05:32 +0100
User-Agent: KMail/1.9.7
References: <200812122326.mBCNQX6w024511@repoman.freebsd.org>
In-Reply-To: <200812122326.mBCNQX6w024511@repoman.freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200812131005.33499.hselasky@c2i.net>
Cc: Perforce Change Reviews <perforce@freebsd.org>
Subject: Re: PERFORCE change 154573 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 13 Dec 2008 09:03:21 -0000

On Saturday 13 December 2008, Sam Leffler wrote:
> http://perforce.freebsd.org/chv.cgi?CH=154573
>
> Change 154573 by sam@sam_ebb on 2008/12/12 23:25:40
>
> 	Checkpoint cambria/ixp435 ehci support: add EHCI_SCFLG_BIGEDESC
> 	flag to force descriptor contents to be left in big-endian byte
> 	order intead of little-endian; this is required by the ixp435
> 	builtin controllers.

I would prefer if you could implement this using ifdefs.

ehcireg.h:

#ifdef HOST_ENDIAN_BUILD
#undef htole32
#define htole32 htobe32
...
#define EXTERNAL(name) name##_be
#else
#define EXTERNAL(name) name##_le
#endif

ehci_wrap.c: (new file)

void
ehci_init(ehci_sc_t *sc)
{
	if (force use bigendian)
		ehci_init_be(sc);
	else
		ehci_init_le(sc);
	return;
}

And the same for all other globally exported functions from ehci.c which are 
not so many!

ehci.c:

void
EXTERNAL(ehci_init)(ehci_sc_t *sc)
{
	... same like before ...
}

ehci_be.c:
#define HOST_ENDIAN_BUILD
#include <sys/dev/usb/ehci.c>

> 	Operations now go through the controller 
> 	and are returned but always w/ an error; still working on why.
>

Maybe a cache sync issue.

--HPS