From owner-svn-src-all@freebsd.org Fri Jul 12 11:44:21 2019 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 5FA8E15ED4D5 for ; Fri, 12 Jul 2019 11:44:21 +0000 (UTC) (envelope-from rrs@netflix.com) Received: from mail-qt1-x82b.google.com (mail-qt1-x82b.google.com [IPv6:2607:f8b0:4864:20::82b]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 3A1206C63C for ; Fri, 12 Jul 2019 11:44:19 +0000 (UTC) (envelope-from rrs@netflix.com) Received: by mail-qt1-x82b.google.com with SMTP id a15so7682946qtn.7 for ; Fri, 12 Jul 2019 04:44:19 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=72dHoLVLuh4p5whkGaIaWBtSQVtJvl+XjXrUFVeI8Ms=; b=bJO2zx5+ePAp38L/PAIdeZlfQhGmmXWOexOcmhiGGZxHE/6aF53MKm1bVNRd+DOmAQ l7pl+vj3XZXpwlyI1zsa80y71bq637XT3AZh0p9vkBXxqy4u08lD4WU18DIDL3+k4UNb oFU7JRpfq1XMSHHLbag/kYvsXLVcKKle0donzf5IEzvD059I5iZj5y8lLC8LhTikFR1M y0ATitQDMcPkCCLBbbWkKQnF5sAWs6+EO/PsXVuqSrwPUPzS9yYiHIkPjkmsEjFJK88U TyyeNYSxVo4yuj2Ctj5QXJ1lzTkTtCYtPeZofppNLf4NwxfpV7XUr7pBmoeWvkcQIqAc /bVA== X-Gm-Message-State: APjAAAU+X57qoteD3pPEVjsU4KDcmig8FR5hnQvpCc1dVR3GTyBof/+M jZ8voZMBdbiN0qKBRy3QOqf8rw== X-Google-Smtp-Source: APXvYqyX+El7ZAJhfA+puyyOcNdMhKgSz9R/cMRcYEOSGoF5N9jK/7zWZGy0ckq4ApAysrtnoAunrg== X-Received: by 2002:a0c:adef:: with SMTP id x44mr6286426qvc.153.1562931858417; Fri, 12 Jul 2019 04:44:18 -0700 (PDT) Received: from ?IPv6:2607:fb10:7061:7fd::19c4? ([2607:fb10:7061:7fd::19c4]) by smtp.gmail.com with ESMTPSA id z8sm3502552qki.23.2019.07.12.04.44.17 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 12 Jul 2019 04:44:17 -0700 (PDT) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 11.5 \(3445.9.1\)) Subject: Re: svn commit: r349907 - head/sys/netinet/tcp_stacks From: Randall Stewart In-Reply-To: <6AC34953-52FC-48FC-B83F-CFFB6A48EC84@gmail.com> Date: Fri, 12 Jul 2019 07:44:16 -0400 Cc: Randall Ray Stewart , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Transfer-Encoding: quoted-printable Message-Id: <9849A15D-6934-4076-9FE9-80AF28F8376C@netflix.com> References: <201907110438.x6B4cXX1054795@repo.freebsd.org> <6AC34953-52FC-48FC-B83F-CFFB6A48EC84@gmail.com> To: Enji Cooper X-Mailer: Apple Mail (2.3445.9.1) X-Rspamd-Queue-Id: 3A1206C63C X-Spamd-Bar: ---------------- X-Spamd-Result: default: False [-16.47 / 15.00]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4000::/36]; MV_CASE(0.50)[]; RCPT_COUNT_FIVE(0.00)[5]; RCVD_COUNT_THREE(0.00)[3]; MX_GOOD(-0.01)[alt1.aspmx.l.google.com,aspmx.l.google.com,aspmx2.googlemail.com,alt2.aspmx.l.google.com,aspmx3.googlemail.com]; DKIM_TRACE(0.00)[netflix.com:+]; DMARC_POLICY_ALLOW(-0.50)[netflix.com,reject]; NEURAL_HAM_SHORT(-0.94)[-0.943,0]; FREEMAIL_TO(0.00)[gmail.com]; FROM_EQ_ENVFROM(0.00)[]; IP_SCORE(-3.02)[ip: (-9.42), ipnet: 2607:f8b0::/32(-3.18), asn: 15169(-2.44), country: US(-0.06)]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; RCVD_TLS_LAST(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; R_DKIM_ALLOW(-0.20)[netflix.com:s=google]; FROM_HAS_DN(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[text/plain]; PREVIOUSLY_DELIVERED(0.00)[svn-src-all@freebsd.org]; TO_MATCH_ENVRCPT_SOME(0.00)[]; WHITELIST_DMARC(-7.00)[netflix.com:D:+]; RCVD_IN_DNSWL_NONE(0.00)[b.2.8.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.b.8.f.7.0.6.2.list.dnswl.org : 127.0.5.0]; WHITELIST_SPF_DKIM(-3.00)[netflix.com:d:+,netflix.com:s:+] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 12 Jul 2019 11:44:21 -0000 opps.. that was a error on my part I will fix it :) > On Jul 11, 2019, at 4:37 AM, Enji Cooper = wrote: >=20 >=20 >> On Jul 10, 2019, at 9:38 PM, Randall Stewart wrote: >>=20 >> Author: rrs >> Date: Thu Jul 11 04:38:33 2019 >> New Revision: 349907 >> URL: https://svnweb.freebsd.org/changeset/base/349907 >>=20 >> Log: >> Update copyright per JBH's suggestions.. thanks. >>=20 >> Modified: >> head/sys/netinet/tcp_stacks/rack.c >>=20 >> Modified: head/sys/netinet/tcp_stacks/rack.c >> = =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D >> --- head/sys/netinet/tcp_stacks/rack.c Thu Jul 11 03:29:25 2019 = (r349906) >> +++ head/sys/netinet/tcp_stacks/rack.c Thu Jul 11 04:38:33 2019 = (r349907) >> @@ -1,5 +1,5 @@ >> /*- >> - * Copyright (c) 2016 >> + * Copyright (c) 2016-2019 >> * Netflix Inc. All rights reserved. >> * >> * Redistribution and use in source and binary forms, with or without >> @@ -8537,10 +8537,10 @@ out: >> * retransmit. In persist state, just set snd_max. >> */ >> if (error =3D=3D 0) { >> -/* if (TCPS_HAVEESTABLISHED(tp->t_state) && >> + if (TCPS_HAVEESTABLISHED(tp->t_state) && >> (tp->t_flags & TF_SACK_PERMIT) && >> tp->rcv_numsacks > 0) >> - tcp_clean_dsack_blocks(tp);*/ >> + tcp_clean_dsack_blocks(tp); >=20 > Removing this commented out code unfortunately broke the build: = https://ci.freebsd.org/job/FreeBSD-head-amd64-LINT/12934/console . > Thanks, > -Enji >=20 ------ Randall Stewart rrs@netflix.com