From owner-svn-ports-head@FreeBSD.ORG Tue Nov 26 08:40:04 2013 Return-Path: Delivered-To: svn-ports-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id DACD2B62; Tue, 26 Nov 2013 08:40:04 +0000 (UTC) Received: from mail-wi0-x230.google.com (mail-wi0-x230.google.com [IPv6:2a00:1450:400c:c05::230]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 723262BC8; Tue, 26 Nov 2013 08:40:03 +0000 (UTC) Received: by mail-wi0-f176.google.com with SMTP id hq4so4809285wib.15 for ; Tue, 26 Nov 2013 00:40:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=XUDEMshLGleJfe31+lAQZLZwjCfrGhxzuJaV+TLjMFE=; b=YzskzFppb+G8aYI178PKFKUfmhOOV3UQMH3caqFuVkxMWhFJBB2QlLlQY11CH4WTC/ /FLwdKxs7glPyvJ/Rkdp+uPxOy8IAvcdyp1TDBKwAFkj4qtlhTGgBnjV4ClMKnmrmAQK tB5hUzfOBuchZhG3Cdnk5aNpmSL2Y+JBcsAvHE7ikZUVH3vnNBsCR9L7n/vXTPqwXZ4Y Jf3w8WbpMb1mjGyobZHJeC9xF871WGVmmXXqfWOlrnXCxdDgo96pAeWGG+P9RixLAxi+ 01TxUSuX05BLa6lkJhmdnGkIOTYvwv3GMer0Mb5b5j6AOaIPcIIrRLRyIHNkg2tG63sI DV1Q== X-Received: by 10.194.21.131 with SMTP id v3mr5431939wje.44.1385455201442; Tue, 26 Nov 2013 00:40:01 -0800 (PST) Received: from ithaqua.etoilebsd.net (ithaqua.etoilebsd.net. [37.59.37.188]) by mx.google.com with ESMTPSA id bs15sm58020733wib.10.2013.11.26.00.39.59 for (version=TLSv1 cipher=RC4-SHA bits=128/128); Tue, 26 Nov 2013 00:40:00 -0800 (PST) Sender: Baptiste Daroussin Date: Tue, 26 Nov 2013 09:39:58 +0100 From: Baptiste Daroussin To: Alexey Dokuchaev Subject: Re: svn commit: r334593 - in head/dns: bind96 bind96/files bind98 bind98/files bind99 bind99/files Message-ID: <20131126083958.GG19582@ithaqua.etoilebsd.net> References: <201311221341.rAMDfY3g002148@svn.freebsd.org> <01490d316b5dd7f01f1c843871542666@secure.marino.st> <2DEEB271-4795-4DF0-8F85-30316BA3070F@FreeBSD.org> <5291C8BD.3070109@marino.st> <20131126035339.GA43389@FreeBSD.org> <20131126073851.GE19582@ithaqua.etoilebsd.net> <20131126075122.GA88351@FreeBSD.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="Fnm8lRGFTVS/3GuM" Content-Disposition: inline In-Reply-To: <20131126075122.GA88351@FreeBSD.org> User-Agent: Mutt/1.5.21 (2010-09-15) Cc: svn-ports-head@freebsd.org, owner-ports-committers@freebsd.org, svn-ports-all@freebsd.org, marino@freebsd.org, ports-committers@freebsd.org, Erwin Lansing X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.16 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 26 Nov 2013 08:40:05 -0000 --Fnm8lRGFTVS/3GuM Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Nov 26, 2013 at 07:51:22AM +0000, Alexey Dokuchaev wrote: > On Tue, Nov 26, 2013 at 08:38:52AM +0100, Baptiste Daroussin wrote: > > On Tue, Nov 26, 2013 at 03:53:39AM +0000, Alexey Dokuchaev wrote: > > > Given that OSVERSION is used extensively in the tree, I'm worrying th= at > > > adding these extra "${OPSYS} =3D=3D FreeBSD" checks will our makefile= s less > > > readable. Wouldn't it make more sense to place this check somewhere = in > > > single place, and define whatever OSVERSION that looks reasonable when > > > OPSYS =3D=3D FreeBSD instead of patching every port? > >=20 > > except that lots/most of the osversion checking in the ports tree is al= so > > wrong and was due to a design bug of pointyhat/tinderbox, pointyhat is = gone, > > and tinderbox had been fixed. there is no need anymore for most of them > > which also are often wrong given the flexibility we have with buildworl= d. > >=20 > > I do plan to remove most of the useless osversion. >=20 > Yup, I remember this was discussed on IRC a few times. I'm only looking > forward to it. However, introducing "${OPSYS} =3D=3D FreeBSD" checks in,= uhm, > *FreeBSD* ports collection looks bogus to me. If BSD wants to > make use of it, fine, but please let's keep their little hacks outside of > FreeBSD ports. :) >=20 > ./danfe We need to be friendly with other OS if they want to use the ports tree like Dragonfly does. and I disagree to let their little hacks outside of the por= ts tree. Their little hacks often shows a deficiency of the port system! for example= the little hack dragonfly had about config.guess/config.sub showed me that we h= ave never upstream our patches to it and we were using a really really old vers= ion, this is one of the reason why most of the autotooled software does not beha= ve the same when built inside and outside of the ports tree. Tricky no? but instead of fixing and upstreaming we have prefered yelling at autotools. (We right know have the same kind of problems with libtool) Their "little hacks" revealed a lot, let allow them to bring it into the "FreeBSD" ports tree! OSVERSION means nothing outside of OSTYPE, and btw OSVERSION is also killin= g the dozens of vendor that keep an old version of freebsd but backporting new th= ings into it! or using a newer version of freebsd but lying on the version to pl= ease the management, or version using "vanilla" freebsd but naming it another na= me or another version. Last thing is their "little hacks" allows me to discover lots of defficiencies about our toolchain and friends, in particular how we handle = it inside the ports tree, this has driven me to the right direction (I hope :)= ) to allow cross building. and OSVERSION is killing me with cross building btw :) My 2cts on the subject. regards, Bapt --Fnm8lRGFTVS/3GuM Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (FreeBSD) iEYEARECAAYFAlKUXl4ACgkQ8kTtMUmk6EwtmACfcsfX1ctIiuiAnML9NYk8t46N f/cAn2umDmP9QqFnb3VeLGG+0o1VCL89 =Bc2Y -----END PGP SIGNATURE----- --Fnm8lRGFTVS/3GuM--