From owner-freebsd-current@FreeBSD.ORG Wed May 5 13:27:18 2004 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E2B8516A4CE; Wed, 5 May 2004 13:27:18 -0700 (PDT) Received: from mail.ambrisko.com (adsl-64-174-51-43.dsl.snfc21.pacbell.net [64.174.51.43]) by mx1.FreeBSD.org (Postfix) with ESMTP id 55E6B43D39; Wed, 5 May 2004 13:27:18 -0700 (PDT) (envelope-from ambrisko@ambrisko.com) Received: from server2.ambrisko.com (HELO www.ambrisko.com) (192.168.1.2) by mail.ambrisko.com with ESMTP; 05 May 2004 13:27:18 -0700 Received: from ambrisko.com (localhost [127.0.0.1]) by www.ambrisko.com (8.12.9p2/8.12.9) with ESMTP id i45KRHjd003514; Wed, 5 May 2004 13:27:17 -0700 (PDT) (envelope-from ambrisko@ambrisko.com) Received: (from ambrisko@localhost) by ambrisko.com (8.12.9p2/8.12.9/Submit) id i45KRHOE003513; Wed, 5 May 2004 13:27:17 -0700 (PDT) (envelope-from ambrisko) From: Doug Ambrisko Message-Id: <200405052027.i45KRHOE003513@ambrisko.com> In-Reply-To: <20040505194949.GA2443@VARK.homeunix.com> To: David Schultz Date: Wed, 5 May 2004 13:27:17 -0700 (PDT) X-Mailer: ELM [version 2.4ME+ PL94b (25)] MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII cc: current@FreeBSD.ORG cc: "=?us-ascii:iso-8859-1?Q?S=F8ren?= Schmidt" Subject: Re: Updated SATA support patches for Intel ICH & Promise cards X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 05 May 2004 20:27:19 -0000 David Schultz writes: | I'm not asking you to do anything extreme like give up | maintainership of the ata driver; that would be detrimental if I strongly agree with this. Soren has tons of ATA knowledge and work arounds. That is a valuable asset that we shouldn't lose. | anything. But Doug has merged his changes with -CURRENT several | times now. I think that with a minimal amount of effort, you | could work more closely with other people who are willing to work | on the ATA driver. Keep in mind that these people are trying to | improve the ATA driver while causing *less* work for you than if | you did it yourself; it ought to be easier to merge someone else's | patch than to write and test the changes yourself. If there's a | technical reason why you don't like someone's changes, please be | upfront about it so they can address your concerns. I can fairly easily re-format things or stick storage of flags/bit in different places. Most of the code I've submitted has been separate functions that can be linked into place. The only code changes I did to the core was to address issues like the dev pointer not being initialized before I needed and linking reset code to recover from a bad SATA state before dealth. The real core of the code is really: - Detect an issue - Deal with the issue I've found if the issues are ignored then bad things start to happen. If the issues are acknowledge then the system is happy. This really has nothing to do with the core ATA code but other bits. I think my patches could be better and tighter integrated with some guidence. I can offer some suggestions some might be usefull others might not or there could be better ways to do things. Granted I'm not going to invest the time merging if they always get rejected. Doug A.