From owner-svn-src-head@freebsd.org Thu Nov 21 16:23:14 2019 Return-Path: Delivered-To: svn-src-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id DA4161C40DE; Thu, 21 Nov 2019 16:23:14 +0000 (UTC) (envelope-from gjb@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [96.47.72.132]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "freefall.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 47JlGp53n7z4cNQ; Thu, 21 Nov 2019 16:23:14 +0000 (UTC) (envelope-from gjb@freebsd.org) Received: from FreeBSD.org (freefall.freebsd.org [IPv6:2610:1c1:1:6074::16:84]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by freefall.freebsd.org (Postfix) with ESMTPS id 1013A124CA; Thu, 21 Nov 2019 16:23:14 +0000 (UTC) (envelope-from gjb@freebsd.org) Date: Thu, 21 Nov 2019 16:23:11 +0000 From: Glen Barber To: Brooks Davis Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org, FreeBSD Ports Management Team , Colin Percival Subject: Re: svn commit: r354909 - in head: . share/mk Message-ID: <20191121162311.GN5599@FreeBSD.org> References: <201911201836.xAKIawWt053874@repo.freebsd.org> <20191121161337.GA92849@FreeBSD.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="mzDsWmoYTs+XRn5Z" Content-Disposition: inline In-Reply-To: <20191121161337.GA92849@FreeBSD.org> User-Agent: Mutt/1.12.1 (2019-06-15) X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 21 Nov 2019 16:23:14 -0000 --mzDsWmoYTs+XRn5Z Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Nov 21, 2019 at 04:13:37PM +0000, Glen Barber wrote: > On Wed, Nov 20, 2019 at 06:36:58PM +0000, Brooks Davis wrote: > > Author: brooks > > Date: Wed Nov 20 18:36:58 2019 > > New Revision: 354909 > > URL: https://svnweb.freebsd.org/changeset/base/354909 > >=20 > > Log: > > Make the warning for deprecated NO_ variables an error. > > =20 > > Support for NO_CTF, NO_DEBUG_FILES, NO_INSTALLLIB, NO_MAN, NO_PROFILE, > > and NO_WARNS as deprecated in 2014 with a warning added for each one > > found. Turn these into error in preperation for removal of compatabil= ity > > support before FreeBSD 13. > > =20 > > Reviewed by: imp > > Relnotes: yes > > Sponsored by: DARPA, AFRL > > Differential Revision: https://reviews.freebsd.org/D22448 > >=20 >=20 > > Modified: head/share/mk/bsd.opts.mk > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D > > --- head/share/mk/bsd.opts.mk Wed Nov 20 18:12:01 2019 (r354908) > > +++ head/share/mk/bsd.opts.mk Wed Nov 20 18:36:58 2019 (r354909) > > @@ -100,7 +100,7 @@ __DEFAULT_DEPENDENT_OPTIONS =3D \ > > PROFILE \ > > WARNS > > .if defined(NO_${var}) > > -.warning "NO_${var} is defined, but deprecated. Please use MK_${var}= =3Dno instead." > > +.error "NO_${var} is defined, but deprecated. Please use MK_${var}=3Dn= o instead." > > MK_${var}:=3Dno > > .endif > > .endfor > >=20 >=20 > Had this been exp-run tested? This breaks at least the > net/bsdec2-image-upload port, which does *not* set NO_MAN explicitly in > its Makefile. I suspect at least several other ports are now implicitly > broken as result of this change. >=20 In fact, on a quick search through ports/*/*/Makefile, I do not see NO_MAN defined *anywhere*. So, this is pulled in from somewhere else, which now I have a feeling more ports than I initially thought are now broken. Glen --mzDsWmoYTs+XRn5Z Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEjRJAPC5sqwhs9k2jAxRYpUeP4pMFAl3Wue8ACgkQAxRYpUeP 4pPRGg//bDDnF4LD6gYlF0cnkgFt+WB3i9gOvZff3dghn4mb1AXyF3GD3BA2W+RY ai5m+bX33CVXQ5tvq/Okk8b+tafGZSBLRidghn8qwa7BQ1IesGbv4Sd1aTvn7lb0 mmKWRfgeI+EJ7Fo6iexUGiz+PpQZxU5B/ROUIvOgSgzGtu3RQMMzEwX4PVUHQW8I 3OjaagyXVDB57iDDT1b/Jje52LfKkIHhaI7D708lhDQRAjso807uTBjeJN/zMWZ1 3kuhegS0VrMBGAm5XAk+M2r6DikhuKk+f3Jof6/1BtFLFhM8Gt11GvOkswSi771T wpRqgARYEb/ad/B1OqxnD99On69xwe5GNboVWQq5Cwx0PpyFJaS1UyJGfHBWUAQo I/DTjAzfn6mfkrWecZFazVCepIU5UqkyZ98CVea35z1nRfwBv6VrFz/8d1w9ds9Z 56bi6WF7qvmyZD1yd3BrU3a/FYFWC//0mf49LuG6szkYwaQT3t/kfwa3oQbkR9AG 3qJ0eAHlkH03kVBF/qmic3z2tUjrjGDQbCeGz2o1X6Z4hbbF98ZV5juMGiZ2owC/ eqQzNKgRIUpxI4qNdOfEQ+yS9t/WJzguKHp4B5SASMEamomSma/OUh7xon+3Xwx4 gCEew0Il7dGgEKc5+Ny1iD8iQRZUsVAAwK0MhDaoBbEmC3IJLGg= =iJyz -----END PGP SIGNATURE----- --mzDsWmoYTs+XRn5Z--