From owner-freebsd-multimedia@FreeBSD.ORG Wed Jan 14 17:01:03 2015 Return-Path: Delivered-To: multimedia@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id D82CD805 for ; Wed, 14 Jan 2015 17:01:03 +0000 (UTC) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id C3E1FC20 for ; Wed, 14 Jan 2015 17:01:03 +0000 (UTC) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.14.9/8.14.9) with ESMTP id t0EH13R9000505 for ; Wed, 14 Jan 2015 17:01:03 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: multimedia@FreeBSD.org Subject: maintainer-feedback requested: [Bug 196729] [patch] multimedia/gstreamer - fix too late occurrence of USES= Date: Wed, 14 Jan 2015 17:01:03 +0000 X-Bugzilla-Type: request Message-ID: In-Reply-To: References: X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: freebsd-multimedia@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Multimedia discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Jan 2015 17:01:03 -0000 John Hein has reassigned Bugzilla Automation 's request for maintainer-feedback to multimedia@FreeBSD.org: Bug 196729: [patch] multimedia/gstreamer - fix too late occurrence of USES= =3D https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D196729 --- Description --- Created attachment 151628 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D151628&action= =3Dedit fix too late USES=3D by replacing bsd.port.pre.mk with bsd.port.options.mk Adding USES settings after bsd.port.pre.mk causes some variables to be set = too late (e.g., *_DEPENDS in Uses/gettext*.mk). For example: before (in current gstreamer port - 0.10.36_2): make -V BUILD_DEPENDS bison:/usr/ports/devel/bison gmake:/usr/ports/devel/gmake pkgconf:/usr/ports/devel/pkgconf /usr/local/bin/flex:/usr/ports/textproc/fl= ex after patch: make -f Makefile -V BUILD_DEPENDS /usr/local/bin/flex:/usr/ports/textproc/flex bison:/usr/ports/devel/bison gmake:/usr/ports/devel/gmake pkgconf:/usr/ports/devel/pkgconf msgfmt:/usr/ports/devel/gettext-tools Note missing gettext-tools in dependency list before the fix. Bumping PORTREVISION is debatable here, but if the package is not rebuilt, = it can have incomplete dependencies (because of missed recording of devel/gettext-runtime in LIB_DEPENDS). It's probably best to bump PORTREVISION, although I did not do so in the attached patch. --- Comment #1 from Bugzilla Automation --- Auto-assigned to maintainer multimedia@FreeBSD.org=