From owner-p4-projects  Tue Dec 17 16:56: 6 2002
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id 45A0837B406; Tue, 17 Dec 2002 16:56:04 -0800 (PST)
Delivered-To: perforce@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id EA59537B401
	for <perforce@freebsd.org>; Tue, 17 Dec 2002 16:56:03 -0800 (PST)
Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115])
	by mx1.FreeBSD.org (Postfix) with ESMTP id DC1EB43EDC
	for <perforce@freebsd.org>; Tue, 17 Dec 2002 16:56:02 -0800 (PST)
	(envelope-from bb+lists.freebsd.perforce@cyrus.watson.org)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id gBI0u2mV078999
	for <perforce@freebsd.org>; Tue, 17 Dec 2002 16:56:02 -0800 (PST)
	(envelope-from bb+lists.freebsd.perforce@cyrus.watson.org)
Received: (from perforce@localhost)
	by repoman.freebsd.org (8.12.6/8.12.6/Submit) id gBI0u2SN078996
	for perforce@freebsd.org; Tue, 17 Dec 2002 16:56:02 -0800 (PST)
Date: Tue, 17 Dec 2002 16:56:02 -0800 (PST)
Message-Id: <200212180056.gBI0u2SN078996@repoman.freebsd.org>
X-Authentication-Warning: repoman.freebsd.org: perforce set sender to bb+lists.freebsd.perforce@cyrus.watson.org using -f
From: Robert Watson <rwatson@FreeBSD.org>
Subject: PERFORCE change 22437 for review
To: Perforce Change Reviews <perforce@freebsd.org>
Sender: owner-p4-projects@FreeBSD.ORG
Precedence: bulk
List-ID: <p4-projects.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20p4-projects>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20p4-projects>
X-Loop: FreeBSD.ORG

http://perforce.freebsd.org/chv.cgi?CH=22437

Change 22437 by rwatson@rwatson_paprika on 2002/12/17 16:55:05

	Perform VOP_GETATTR() before mac_check_vnode_exec() so that
	the cached attributes are available to MAC modules.
	
	Submitted by:	mike halderman <mrh@nosc.mil>

Affected files ...

.. //depot/projects/trustedbsd/mac/sys/kern/kern_exec.c#51 edit

Differences ...

==== //depot/projects/trustedbsd/mac/sys/kern/kern_exec.c#51 (text+ko) ====

@@ -1101,17 +1101,17 @@
 
 	td = curthread;			/* XXXKSE */
 
+	/* Get file attributes */
+	error = VOP_GETATTR(vp, attr, td->td_ucred, td);
+	if (error)
+		return (error);
+
 #ifdef MAC
 	error = mac_check_vnode_exec(td->td_ucred, imgp->vp, imgp);
 	if (error)
 		return (error);
 #endif
 	
-	/* Get file attributes */
-	error = VOP_GETATTR(vp, attr, td->td_ucred, td);
-	if (error)
-		return (error);
-
 	/*
 	 * 1) Check if file execution is disabled for the filesystem that this
 	 *	file resides on.

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe p4-projects" in the body of the message