From owner-svn-src-all@freebsd.org Wed Jan 24 15:44:19 2018 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 6C1B7ED9DF3 for ; Wed, 24 Jan 2018 15:44:19 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-it0-x22f.google.com (mail-it0-x22f.google.com [IPv6:2607:f8b0:4001:c0b::22f]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id CCD028E7D9 for ; Wed, 24 Jan 2018 15:44:18 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-it0-x22f.google.com with SMTP id b5so5662624itc.3 for ; Wed, 24 Jan 2018 07:44:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=ky9iXbe31AwKkkQ7NuyZsOSQOdk7mD/uA0k9iUMnPmo=; b=eOm+jZPBhWyb2ukVsUcGGtOnMDBgv4uhVIqiTtzklAZGs+QBip/4zPq2ajyrVc6Z4A Hs72bwtnd6NyLzZ06GCqIo3cRlQNg88+kK4SeuRo6+y4WEIklUdsigbfQmfkeU/mCbxg ZZ7IJ7tQsyKFFpMnhfhQG16ClbdKeJ/wkT09BTwYm4NyhinS/0V6kDG3/J4Tes4vpQrc DZ3Pn12Z1WBEVGA1DlEpXyDU5EVxz+i227t8pFdOaB14Ri6bhYGbbIE3FDeR5MeRY2bV hhyFDVG2YXgO1Xm55PG9D/nF6aCeqcUjYJN0aEHTqurD96g9+2aJKn06F4IxhYDqVF17 Ok8Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=ky9iXbe31AwKkkQ7NuyZsOSQOdk7mD/uA0k9iUMnPmo=; b=FLo54naYqlrWLwH+LznYhajPdAZpHDgNRVIdNYGW28e9m73DfrpaDClOpwqyG8ilX/ NLCMARANAz4Vwb0aR/DakVsSJs4VJnBE2NKSrljXZt9Ll1p5y88wRMJIyOR9IyLeXHtK RMfBPlrBrdynZeWlL/oXMi/yM5/jMriTIhFQoIIOZ02iWQ6tS1bpiJtVn5w32gM3Fi41 XepU1Lux3Q5BsWuj5iAOEREDa08DAccWhdnAUQxHGR1aBuV05a9LM776IEX6NtaXViZ4 zfmQlGWkHO1gWJGDmgGJfGCGm99kZZgjPl6KuvaOPIRK2XTmejdezd7BE/WdychwrjgW qPHQ== X-Gm-Message-State: AKwxyteFHFHV/HjwcLOmBYfEsrLqrjq9p5vGJDNiWwW7DUGxEVSEFE++ jsxnR4Js1SuskVjCtHWJmjzt51fgvFv4SVk++huBTQ== X-Google-Smtp-Source: AH8x224btxDOdQ8/yoAILMUr/oyQbTBCBx5iiCk6T5K58FP01tO29mrw64PMC1e8OuqJr/SnklYOFZJ5p+L4T/SZbKo= X-Received: by 10.36.91.210 with SMTP id g201mr9124186itb.50.1516808658037; Wed, 24 Jan 2018 07:44:18 -0800 (PST) MIME-Version: 1.0 Sender: wlosh@bsdimp.com Received: by 10.79.153.28 with HTTP; Wed, 24 Jan 2018 07:44:16 -0800 (PST) X-Originating-IP: [50.227.106.226] In-Reply-To: <20180124182548.X1063@besplex.bde.org> References: <201801211542.w0LFgbsp005980@repo.freebsd.org> <51ff8aef-5660-7857-e4d5-12cdc77bc071@FreeBSD.org> <20180124182548.X1063@besplex.bde.org> From: Warner Losh Date: Wed, 24 Jan 2018 08:44:16 -0700 X-Google-Sender-Auth: UEs8OP-s76c_BpVLs6eFFalfnb0 Message-ID: Subject: Re: svn commit: r328218 - in head/sys: amd64/amd64 arm/xscale/ixp425 arm64/arm64 cam cam/ctl compat/ndis dev/aacraid dev/advansys dev/ath dev/beri/virtio dev/bnxt dev/bwn dev/ciss dev/cxgbe/crypto dev/... To: Bruce Evans Cc: Pedro Giffuni , "Conrad E. Meyer" , src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.25 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 24 Jan 2018 15:44:19 -0000 On Wed, Jan 24, 2018 at 1:50 AM, Bruce Evans wrote: > On Tue, 23 Jan 2018, Pedro Giffuni wrote: > > On 23/01/2018 14:08, Conrad Meyer wrote: >> >>> Hi Pedro, >>> >>> On Sun, Jan 21, 2018 at 7:42 AM, Pedro F. Giffuni >>> wrote: >>> >>>> Author: pfg >>>> Date: Sun Jan 21 15:42:36 2018 >>>> New Revision: 328218 >>>> URL: https://svnweb.freebsd.org/changeset/base/328218 >>>> >>>> Log: >>>> Revert r327828, r327949, r327953, r328016-r328026, r328041: >>>> Uses of mallocarray(9). >>>> >>>> The use of mallocarray(9) has rocketed the required swap to build >>>> FreeBSD. >>>> This is likely caused by the allocation size attributes which put >>>> extra pressure >>>> on the compiler. >>>> >>> I'm confused about this change. Wouldn't it be better to remove the >>> annotation/attributes from mallocarray() than to remove the protection >>> against overflow? >>> >> > It would be better to remove mallocarray(). I agree completely. It doesn't do what you think it is doing, for all the reasons that Bruce outlines. We thought it was a bad idea when it came up 2 years ago and nothing has really changed. Warner