Date: Fri, 31 Mar 2017 20:22:14 +0000 From: bugzilla-noreply@freebsd.org To: freebsd-ports-bugs@FreeBSD.org Subject: [Bug 218271] sysutils/qjail [Maintainer update] fix bugs Message-ID: <bug-218271-13@https.bugs.freebsd.org/bugzilla/>
next in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D218271 Bug ID: 218271 Summary: sysutils/qjail [Maintainer update] fix bugs Product: Ports & Packages Version: Latest Hardware: Any OS: Any Status: New Severity: Affects Many People Priority: --- Component: Individual Port(s) Assignee: freebsd-ports-bugs@FreeBSD.org Reporter: joeb1@a1poweruser.com CC: qjail1@a1poweruser.com Flags: maintainer-feedback?(qjail1@a1poweruser.com) CC: qjail1@a1poweruser.com Created attachment 181361 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D181361&action= =3Dedit port diff 1. Some people have firewalls that are not or cannot be configured to allow= ftp out. qjail used native ftp to download the base file issued by the "qjail install" logic. Changed it to use the "fetch http" command instead of the native ftp command.=20 2. Installed the hs-shellcheck package. Used it to check the qjail script. = Even though the qjail script has been in production mode for 7+ years, thought it would be good to verify the code was up to good standards. It found some th= ings that were not up to standard that I fixed. The changes in no way effected t= he existing logic flow. 3. Ran the updated qjail script through a testing cycle looking for any problems that may have been caused by the shellcheck changes I made. None w= ere found. 4. The testing cycle did bring to light three problems that unknowingly exi= sted before the shellcheck changes were made. A. The verify_ip routine was not working correctly. Fixed it. B. The bpf devfs rule 50 was not working correctly. Fixed it. C. Added check to -d option [# of jails to duplicate] of the=20 create function. No IPv6 addresses are allowed, only a single IPv4 address is allowed. 5. Ran shellcheck on "qjail.bootime" script and fixed same kind of things a= s in the qjail script. --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-218271-13>