From owner-freebsd-current@FreeBSD.ORG Sun Feb 24 15:25:52 2013 Return-Path: Delivered-To: current@freebsd.org Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115]) by hub.freebsd.org (Postfix) with ESMTP id EB529E5A; Sun, 24 Feb 2013 15:25:52 +0000 (UTC) (envelope-from david@catwhisker.org) Received: from albert.catwhisker.org (m209-73.dsl.rawbw.com [198.144.209.73]) by mx1.freebsd.org (Postfix) with ESMTP id 9682E6C7; Sun, 24 Feb 2013 15:25:52 +0000 (UTC) Received: from albert.catwhisker.org (localhost [127.0.0.1]) by albert.catwhisker.org (8.14.6/8.14.6) with ESMTP id r1OFPqRA003045; Sun, 24 Feb 2013 07:25:52 -0800 (PST) (envelope-from david@albert.catwhisker.org) Received: (from david@localhost) by albert.catwhisker.org (8.14.6/8.14.6/Submit) id r1OFPq5U003044; Sun, 24 Feb 2013 07:25:52 -0800 (PST) (envelope-from david) Date: Sun, 24 Feb 2013 07:25:52 -0800 From: David Wolfskill To: current@freebsd.org Subject: Re: [PATCH] Fix sbin/fsdb/fsdbutil.c for r247212 Message-ID: <20130224152552.GB2785@albert.catwhisker.org> References: <20130224150534.GA2785@albert.catwhisker.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="sgneBHv3152wZ8jf" Content-Disposition: inline In-Reply-To: <20130224150534.GA2785@albert.catwhisker.org> User-Agent: Mutt/1.5.21 (2010-09-15) Cc: Kirk McKusick X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 24 Feb 2013 15:25:53 -0000 --sgneBHv3152wZ8jf Content-Type: multipart/mixed; boundary="Md/poaVZ8hnGTzuv" Content-Disposition: inline --Md/poaVZ8hnGTzuv Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Feb 24, 2013 at 07:05:34AM -0800, David Wolfskill wrote: > ...hine was: > Simple patch attached; world is still building, but at least it got > through the "make dependencies" phase this time. > ... That was incomplete, as it didn't (also) address the change to getdatablk(). The attached patch actually made it through buildworld. Note that it is entirely possible that I erred in specifying "BT_UNKNOWN" for the additional "type" argument. Peace, david --=20 David H. Wolfskill david@catwhisker.org Taliban: Evil men with guns afraid of truth from a 14-year old girl. See http://www.catwhisker.org/~david/publickey.gpg for my public key. --Md/poaVZ8hnGTzuv Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="fsdbutil.c.patch" Content-Transfer-Encoding: quoted-printable Index: sbin/fsdb/fsdbutil.c =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D --- sbin/fsdb/fsdbutil.c (revision 247218) +++ sbin/fsdb/fsdbutil.c (working copy) @@ -239,11 +239,11 @@ /* for the final indirect level, don't use the cache */ bp =3D &buf; bp->b_un.b_buf =3D bufp; - initbarea(bp); + initbarea(bp, BT_UNKNOWN); =20 getblk(bp, blk, sblock.fs_bsize); } else - bp =3D getdatablk(blk, sblock.fs_bsize); + bp =3D getdatablk(blk, sblock.fs_bsize, BT_UNKNOWN); =20 cpl =3D charsperline(); for (i =3D charssofar =3D 0; i < NINDIR(&sblock); i++) { --Md/poaVZ8hnGTzuv-- --sgneBHv3152wZ8jf Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (FreeBSD) iEYEARECAAYFAlEqMP8ACgkQmprOCmdXAD3LDACeLZ4syFP5HGQISbqz9RuUm9Vz DpIAnRmYNQU7GxV25ARO/glHJDTmvMyu =HT8v -----END PGP SIGNATURE----- --sgneBHv3152wZ8jf--