From owner-freebsd-net Tue Mar 27 3:12:51 2001 Delivered-To: freebsd-net@freebsd.org Received: from freesbee.wheel.dk (freesbee.wheel.dk [193.162.159.97]) by hub.freebsd.org (Postfix) with ESMTP id 6495A37B71A; Tue, 27 Mar 2001 03:12:48 -0800 (PST) (envelope-from jesper@skriver.dk) Received: by freesbee.wheel.dk (Postfix, from userid 1001) id 1D6515D68; Tue, 27 Mar 2001 13:12:47 +0200 (CEST) Date: Tue, 27 Mar 2001 13:12:47 +0200 From: Jesper Skriver To: Jeroen Ruigrok/Asmodai Cc: Bill Fenner , net@freebsd.org, jlemon@freebsd.org Subject: Re: 4.3 issue: new ICMP handling broke date(1) Message-ID: <20010327131246.A71551@skriver.dk> References: <200103261557.JAA08568@windsor.research.att.com> <20010327124531.O68667@daemon.ninth-circle.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: <20010327124531.O68667@daemon.ninth-circle.org>; from asmodai@wxs.nl on Tue, Mar 27, 2001 at 12:45:31PM +0200 X-PGP-Fingerprint: 6B88 9CE8 66E9 E631 C9C5 5EB4 22AB F0EC F956 1C31 X-PGP-Public-Key: http://freesbee.wheel.dk/~jesper/gpgkey.pub Sender: owner-freebsd-net@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.org On Tue, Mar 27, 2001 at 12:45:31PM +0200, Jeroen Ruigrok/Asmodai wrote: > [making sure Jesper and Jonathan see this] > > -On [20010326 18:00], Bill Fenner (fenner@research.att.com) wrote: > >Now that an ICMP port unreachable returns ENETRESET and not ECONNREFUSED, > >setting the date on the command line results in a bogusly-reported error. > >Before you fix the bug in date/netdate.c, it tends to report EADDRINUSE; > >afterwards it tends to report ENETRESET. > > > >Why did the handling of "udp port unreachable" have to change? ECONNREFUSED > >was a perfectly fine return value for that. I'm reasonably sure that > >there are other programs out there that think that ECONNREFUSED is what > >you get when you get an ICMP port unreachable back after a UDP send, > >so I doubt that the answer is to simply fix date(1). > > FWIW I think the correct thing would be to return ECONNREFUSED. > > Looking at intro(2) it would seem that ECONNREFUSED fits the shoe since > the connection is actively refused. So do I, I'll have a look at the code tonight ... /Jesper -- Jesper Skriver, jesper(at)skriver(dot)dk - CCIE #5456 Work: Network manager @ AS3292 (Tele Danmark DataNetworks) Private: FreeBSD committer @ AS2109 (A much smaller network ;-) One Unix to rule them all, One Resolver to find them, One IP to bring them all and in the zone to bind them. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-net" in the body of the message