From owner-freebsd-acpi@FreeBSD.ORG  Wed Nov  3 07:43:05 2010
Return-Path: <owner-freebsd-acpi@FreeBSD.ORG>
Delivered-To: freebsd-acpi@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 5BEBD106564A;
	Wed,  3 Nov 2010 07:43:05 +0000 (UTC)
	(envelope-from hselasky@c2i.net)
Received: from swip.net (mailfe02.swip.net [212.247.154.33])
	by mx1.freebsd.org (Postfix) with ESMTP id 613F28FC12;
	Wed,  3 Nov 2010 07:43:03 +0000 (UTC)
X-Cloudmark-Score: 0.000000 []
X-Cloudmark-Analysis: v=1.1 cv=yevn+QCjI6xy199BDvBOOiO14qYvyLq62he9tTtU3M8=
	c=1 sm=1 a=Q9fys5e9bTEA:10 a=CL8lFSKtTFcA:10
	a=i9M/sDlu2rpZ9XS819oYzg==:17 a=RBRriF4cpPnANc770RMA:9
	a=cz7Tf2TqI69XLjceedBROGzNMBcA:4 a=PUjeQqilurYA:10
	a=Ai_k5aZwGu2DL3zR:21 a=fdMMrA_9WYEwGpS1:21
	a=i9M/sDlu2rpZ9XS819oYzg==:117
Received: from [188.126.198.129] (account mc467741@c2i.net HELO
	laptop002.hselasky.homeunix.org)
	by mailfe02.swip.net (CommuniGate Pro SMTP 5.2.19)
	with ESMTPA id 43883870; Wed, 03 Nov 2010 08:43:02 +0100
From: Hans Petter Selasky <hselasky@c2i.net>
To: "Jung-uk Kim" <jkim@freebsd.org>
Date: Wed, 3 Nov 2010 08:44:13 +0100
User-Agent: KMail/1.13.5 (FreeBSD/8.1-STABLE; KDE/4.4.5; amd64; ; )
References: <201010121209.06397.hselasky@c2i.net>
	<4CD02E6D.1070106@freebsd.org>
	<201011021529.05977.jkim@FreeBSD.org>
In-Reply-To: <201011021529.05977.jkim@FreeBSD.org>
X-Face: +~\`s("[*<S!NI[0M*"FaghA8S>|O,="7?X@L.elg*F"OA\I/3%^p8g?ab%RN'(; _IjlA:
	hGE..Ew, XAQ*o#\/M~SC=S1-f9{EzRfT'|Hhll5Q]ha5Bt-s|oTlKMusi:1e[wJl}kd}GR
	Z0adGx-x_0zGbZj'e(Y[(UNle~)8CQWXW@:DX+9)_YlB[tIccCPN$7/L'
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="iso-8859-15"
Content-Transfer-Encoding: 7bit
Message-Id: <201011030844.13412.hselasky@c2i.net>
Cc: freebsd-acpi@freebsd.org, Lin Ming <ming.m.lin@intel.com>,
	Andriy Gapon <avg@freebsd.org>, "Moore, Robert" <robert.moore@intel.com>
Subject: Re: MacBookPro 5,1
X-BeenThere: freebsd-acpi@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: ACPI and power management development <freebsd-acpi.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-acpi>,
	<mailto:freebsd-acpi-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-acpi>
List-Post: <mailto:freebsd-acpi@freebsd.org>
List-Help: <mailto:freebsd-acpi-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-acpi>,
	<mailto:freebsd-acpi-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 03 Nov 2010 07:43:05 -0000

On Tuesday 02 November 2010 20:29:01 Jung-uk Kim wrote:
> On Tuesday 02 November 2010 11:29 am, Andriy Gapon wrote:
> > on 29/10/2010 08:51 Andriy Gapon said the following:
> > > I guess that a general problem here is that it is incorrect to
> > > merely use memcpy/bcopy to create a copy of a resource if the
> > > resource has ACPI_RESOURCE_SOURCE field in it.
> > 
> > Hans,
> > 
> > could you please test the following patch?
> > 
> > diff --git a/sys/dev/acpica/acpi_pci_link.c
> > b/sys/dev/acpica/acpi_pci_link.c index dcf101d..e842635 100644
> > --- a/sys/dev/acpica/acpi_pci_link.c
> > +++ b/sys/dev/acpica/acpi_pci_link.c
> > @@ -767,6 +767,8 @@ acpi_pci_link_srs_from_crs
> > 
> >  				    link->l_irq;
> >  			
> >  			else
> >  			
> >  				resptr->Data.ExtendedIrq.Interrupts[0] = 0;
> > 
> > +			memset(&resptr->Data.ExtendedIrq.ResourceSource, 0,
> > +			    sizeof(ACPI_RESOURCE_SOURCE));
> > 
> >  			link++;
> >  			i++;
> >  			break;
> 
> Hmm...  Very interesting.  Can you please try this, too?
> 
> Thanks,
> 
> Jung-uk Kim

Hi,

I will try to get your patches tested in less than 10 hours from now.

--HPS