Date: Wed, 13 Sep 2017 02:27:36 +0000 (UTC) From: "Carlos J. Puga Medina" <cpm@FreeBSD.org> To: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: svn commit: r449749 - in head/deskutils/go-for-it: . files Message-ID: <201709130227.v8D2RbSO058105@repo.freebsd.org>
next in thread | raw e-mail | index | archive | help
Author: cpm Date: Wed Sep 13 02:27:36 2017 New Revision: 449749 URL: https://svnweb.freebsd.org/changeset/ports/449749 Log: deskutils/go-for-it: unbreak build with vala 0.36 /wrkdirs/usr/ports/deskutils/go-for-it/work/Go-For-It-release_v1.5/src/TaskStore.vala:89.22-89.25: error: Argument 1: Cannot pass value to reference or output parameter this.remove (iter); ^^^^ While I'm here, pet portlint, USE_* comes before USES PR: 222036 Submitted by: cpm Approved by: Neel Chauhan <neel@neelc.org> (maintainer) Added: head/deskutils/go-for-it/files/ head/deskutils/go-for-it/files/patch-src_TaskStore.vala (contents, props changed) Modified: head/deskutils/go-for-it/Makefile Modified: head/deskutils/go-for-it/Makefile ============================================================================== --- head/deskutils/go-for-it/Makefile Wed Sep 13 02:04:45 2017 (r449748) +++ head/deskutils/go-for-it/Makefile Wed Sep 13 02:27:36 2017 (r449749) @@ -14,14 +14,14 @@ LICENSE_FILE= ${WRKSRC}/COPYING BUILD_DEPENDS= valac:lang/vala LIB_DEPENDS= libnotify.so:devel/libnotify -USE_GITHUB= yes -GH_ACCOUNT= mank319 -GH_PROJECT= Go-For-It - -GNU_CONFIGURE= yes USES= cmake gettext pkgconfig USE_GNOME= cairo glib20 gtk30 +GNU_CONFIGURE= yes INSTALLS_ICONS= yes + +USE_GITHUB= yes +GH_ACCOUNT= mank319 +GH_PROJECT= Go-For-It post-install: ${INSTALL_DATA} ${WRKSRC}/data/go-for-it.desktop \ Added: head/deskutils/go-for-it/files/patch-src_TaskStore.vala ============================================================================== --- /dev/null 00:00:00 1970 (empty, because file is newly added) +++ head/deskutils/go-for-it/files/patch-src_TaskStore.vala Wed Sep 13 02:27:36 2017 (r449749) @@ -0,0 +1,14 @@ +--- src/TaskStore.vala.orig 2016-12-18 13:54:36 UTC ++++ src/TaskStore.vala +@@ -86,7 +86,11 @@ class TaskStore : Gtk.ListStore { + public void remove_task (Gtk.TreeIter iter) { + bool is_active_task = compare_tasks (iter); + var _active_task = active_task; ++#if VALA_0_36 ++ this.remove (ref iter); ++#else + this.remove (iter); ++#endif + if (is_active_task && _active_task == active_task) { + active_task = null; + refresh_active_task ();
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201709130227.v8D2RbSO058105>